From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2005EC2BB55 for ; Thu, 16 Apr 2020 16:49:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF7332076D for ; Thu, 16 Apr 2020 16:49:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="U1chH8R3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727832AbgDPQty (ORCPT ); Thu, 16 Apr 2020 12:49:54 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:42144 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727784AbgDPQtx (ORCPT ); Thu, 16 Apr 2020 12:49:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YV1SAfrAwp0QaVFTYO0FSHpHPtlvDBOUkjggRuVS/W8=; b=U1chH8R3kb8KUrAc+3eJQcTwn8 MDeJ/6p6u6fCmyrzaVmLr9Xb6n3BfYIsD259+oy6rHF4k2JzBkGCqhwGM0b6b4HKVg+dJC+TV2aK1 YgUNOK/LU5DIofyvIIgLUhYeSZqEKS+dN67H3LP8yGRucvVgDoD+WS2eBNyQK/H6Nlao=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jP7hw-0036fC-15; Thu, 16 Apr 2020 18:49:44 +0200 Date: Thu, 16 Apr 2020 18:49:44 +0200 From: Andrew Lunn To: Robin Murphy Cc: Linus Walleij , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jason Cooper , "open list:GPIO SUBSYSTEM" , Gregory Clement , Russell King - ARM Linux admin , linux-pwm@vger.kernel.org, Bartosz Golaszewski , Rob Herring , Thierry Reding , Uwe Kleine-Konig , Linux ARM , Sebastian Hesselbarth Subject: Re: [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Message-ID: <20200416164944.GS657811@lunn.ch> References: <20200329104549.GX25745@shell.armlinux.org.uk> <20200416135039.GL657811@lunn.ch> <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> <20200416144231.GP657811@lunn.ch> <628cde2b-0e1b-4c07-4321-8b23d0b34384@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <628cde2b-0e1b-4c07-4321-8b23d0b34384@arm.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org > > It is not really hope. It is very obvious when it is wrong, the whole > > machine stops dead when you are missing a clock. Very simple to test. > > Heh, that's still what I meant - the driver hopes that carrying on will be > OK, and the end user is left to pick up the pieces when it isn't ;) > Obviously that's less of an issue when said end-user is a kernel developer > making a controlled change during SoC bringup, but perhaps more so for an > eager inexperienced hacker cobbling together DTS fragments to convince a > distro kernel to boot on some embedded device Clocks are SoC level stuff, so it is in the DTSI file, not the DTS file. An eager inexperienced hacker cobbling together DTS fragment is not effected. Experienced kernel hackers have put together the DTSI file and tested it. And if an eager inexperienced hacker does touch the DTSI file, they probably deserve to get their finger burnt, and will get a step closer to become an experience kernel hacker. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF29C2BB55 for ; Thu, 16 Apr 2020 16:50:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F5B22076D for ; Thu, 16 Apr 2020 16:50:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lhkfVSTn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="U1chH8R3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F5B22076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gGbW4s4XqcZGr5vgkwXKLrGMkjbfVnuYZMXVusUSFD4=; b=lhkfVSTn1m0plh rXRhQnAkG/zm6uQdISh++6BvjYcXLGJEs+81pi2xo392baWuf33PsrNUaLIa3fJbDLxyczUwsF3oG udy7caUVP7GDfFnXpbB+j7N9LK1TF5B7slk5kL3W6ZKi6DTsKOgx7Ub8wjBCcJdUx6VyEfrhbTLHO z5olBEgIAieo/3t10pCNreTcyXezNdOHuhp8eTmr9nhxP5NbXsHKyrVhi7HpHAcE6wNqLYIqOuAwJ B4LK8sb9M00WeNgwKzjBsD13UtDhui6HK1iH50JjduiGWiIWDgw3RaJQslB8eQjK/cktS7XsPBuPs N9d2/Rxk8eN+B393OuqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP7iE-0005uL-Os; Thu, 16 Apr 2020 16:50:03 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jP7i9-0005m2-CC for linux-arm-kernel@lists.infradead.org; Thu, 16 Apr 2020 16:50:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YV1SAfrAwp0QaVFTYO0FSHpHPtlvDBOUkjggRuVS/W8=; b=U1chH8R3kb8KUrAc+3eJQcTwn8 MDeJ/6p6u6fCmyrzaVmLr9Xb6n3BfYIsD259+oy6rHF4k2JzBkGCqhwGM0b6b4HKVg+dJC+TV2aK1 YgUNOK/LU5DIofyvIIgLUhYeSZqEKS+dN67H3LP8yGRucvVgDoD+WS2eBNyQK/H6Nlao=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jP7hw-0036fC-15; Thu, 16 Apr 2020 18:49:44 +0200 Date: Thu, 16 Apr 2020 18:49:44 +0200 From: Andrew Lunn To: Robin Murphy Subject: Re: [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Message-ID: <20200416164944.GS657811@lunn.ch> References: <20200329104549.GX25745@shell.armlinux.org.uk> <20200416135039.GL657811@lunn.ch> <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com> <20200416144231.GP657811@lunn.ch> <628cde2b-0e1b-4c07-4321-8b23d0b34384@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <628cde2b-0e1b-4c07-4321-8b23d0b34384@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200416_094957_441246_BEE8027E X-CRM114-Status: GOOD ( 12.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jason Cooper , linux-pwm@vger.kernel.org, Linus Walleij , Russell King - ARM Linux admin , "open list:GPIO SUBSYSTEM" , Rob Herring , Thierry Reding , Uwe Kleine-Konig , Bartosz Golaszewski , Gregory Clement , Linux ARM , Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > It is not really hope. It is very obvious when it is wrong, the whole > > machine stops dead when you are missing a clock. Very simple to test. > > Heh, that's still what I meant - the driver hopes that carrying on will be > OK, and the end user is left to pick up the pieces when it isn't ;) > Obviously that's less of an issue when said end-user is a kernel developer > making a controlled change during SoC bringup, but perhaps more so for an > eager inexperienced hacker cobbling together DTS fragments to convince a > distro kernel to boot on some embedded device Clocks are SoC level stuff, so it is in the DTSI file, not the DTS file. An eager inexperienced hacker cobbling together DTS fragment is not effected. Experienced kernel hackers have put together the DTSI file and tested it. And if an eager inexperienced hacker does touch the DTSI file, they probably deserve to get their finger burnt, and will get a step closer to become an experience kernel hacker. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel