From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge Date: Thu, 16 Apr 2020 23:50:12 +0300 Message-ID: <20200416205012.GA28162@pendragon.ideasonboard.com> References: <20200416172405.5051-1-digetx@gmail.com> <20200416172405.5051-3-digetx@gmail.com> <20200416174112.GS4796@pendragon.ideasonboard.com> <6275bcd3-c0b2-4c1c-1817-9e713d3747c7@gmail.com> <7cf27640-4fdc-8617-01cb-85f4c5847bb8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <7cf27640-4fdc-8617-01cb-85f4c5847bb8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko Cc: Thierry Reding , Sam Ravnborg , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi Dmitry, On Thu, Apr 16, 2020 at 11:21:40PM +0300, Dmitry Osipenko wrote: > 16.04.2020 21:52, Dmitry Osipenko пишет: > ... > >> May I also recommend switching to the DRM panel bridge helper ? It will > >> simplify the code. > > > > Could you please clarify what is the "DRM panel bridge helper"? > > > > I think we won't need any additional helpers after switching to the > > bridge connector helper, no? > > Actually, I now see that the panel needs to be manually attached to the > connector. The DRM panel bridge helper creates a bridge from a panel (with devm_drm_panel_bridge_add()). You can then attach that bridge to the chain, like any other bridge, and the enable/disable operations will be called automatically without any need to call the panel enable/disable manually as done currently. > Still it's not apparent to me how to get panel out of the bridge. It > looks like there is no such "panel helper" for the bridge API or I just > can't find it. You don't need to get a panel out of the bridge. You should get the bridge as done today, and wrap it in a bridge with devm_drm_panel_bridge_add(). -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED2D6C2BA2B for ; Thu, 16 Apr 2020 20:50:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CFF1221F7 for ; Thu, 16 Apr 2020 20:50:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GOwCpuEh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CFF1221F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FA0E6E0E4; Thu, 16 Apr 2020 20:50:29 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id F06E86E0E4 for ; Thu, 16 Apr 2020 20:50:27 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 577CA97D; Thu, 16 Apr 2020 22:50:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1587070224; bh=+3HruF7BWI3dgo7B6OhbPOuvAroBWE8pf/TumbaPCNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GOwCpuEhOVC5GevTvJXEoi/Qk7P1KlX897QfWZMYhfj4ComYApD7KvhqkllmU19mP QldRhosz0iZgv73AxKq3hbxz4Q1RDTJXLXX0uV0Pc3hFo4bxYuDTfakUEaiF0aWeID T94H6CCO0JaBNJsP6wmSzCTC6+UjjieK9mSOxKwQ= Date: Thu, 16 Apr 2020 23:50:12 +0300 From: Laurent Pinchart To: Dmitry Osipenko Subject: Re: [PATCH v3 2/2] drm/tegra: output: rgb: Support LVDS encoder bridge Message-ID: <20200416205012.GA28162@pendragon.ideasonboard.com> References: <20200416172405.5051-1-digetx@gmail.com> <20200416172405.5051-3-digetx@gmail.com> <20200416174112.GS4796@pendragon.ideasonboard.com> <6275bcd3-c0b2-4c1c-1817-9e713d3747c7@gmail.com> <7cf27640-4fdc-8617-01cb-85f4c5847bb8@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7cf27640-4fdc-8617-01cb-85f4c5847bb8@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Thierry Reding , Sam Ravnborg , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgRG1pdHJ5LAoKT24gVGh1LCBBcHIgMTYsIDIwMjAgYXQgMTE6MjE6NDBQTSArMDMwMCwgRG1p dHJ5IE9zaXBlbmtvIHdyb3RlOgo+IDE2LjA0LjIwMjAgMjE6NTIsIERtaXRyeSBPc2lwZW5rbyDQ v9C40YjQtdGCOgo+IC4uLgo+ID4+IE1heSBJIGFsc28gcmVjb21tZW5kIHN3aXRjaGluZyB0byB0 aGUgRFJNIHBhbmVsIGJyaWRnZSBoZWxwZXIgPyBJdCB3aWxsCj4gPj4gc2ltcGxpZnkgdGhlIGNv ZGUuCj4gPiAKPiA+IENvdWxkIHlvdSBwbGVhc2UgY2xhcmlmeSB3aGF0IGlzIHRoZSAiRFJNIHBh bmVsIGJyaWRnZSBoZWxwZXIiPwo+ID4gCj4gPiBJIHRoaW5rIHdlIHdvbid0IG5lZWQgYW55IGFk ZGl0aW9uYWwgaGVscGVycyBhZnRlciBzd2l0Y2hpbmcgdG8gdGhlCj4gPiBicmlkZ2UgY29ubmVj dG9yIGhlbHBlciwgbm8/Cj4gCj4gQWN0dWFsbHksIEkgbm93IHNlZSB0aGF0IHRoZSBwYW5lbCBu ZWVkcyB0byBiZSBtYW51YWxseSBhdHRhY2hlZCB0byB0aGUKPiBjb25uZWN0b3IuCgpUaGUgRFJN IHBhbmVsIGJyaWRnZSBoZWxwZXIgY3JlYXRlcyBhIGJyaWRnZSBmcm9tIGEgcGFuZWwgKHdpdGgK ZGV2bV9kcm1fcGFuZWxfYnJpZGdlX2FkZCgpKS4gWW91IGNhbiB0aGVuIGF0dGFjaCB0aGF0IGJy aWRnZSB0byB0aGUKY2hhaW4sIGxpa2UgYW55IG90aGVyIGJyaWRnZSwgYW5kIHRoZSBlbmFibGUv ZGlzYWJsZSBvcGVyYXRpb25zIHdpbGwgYmUKY2FsbGVkIGF1dG9tYXRpY2FsbHkgd2l0aG91dCBh bnkgbmVlZCB0byBjYWxsIHRoZSBwYW5lbCBlbmFibGUvZGlzYWJsZQptYW51YWxseSBhcyBkb25l IGN1cnJlbnRseS4KCj4gU3RpbGwgaXQncyBub3QgYXBwYXJlbnQgdG8gbWUgaG93IHRvIGdldCBw YW5lbCBvdXQgb2YgdGhlIGJyaWRnZS4gSXQKPiBsb29rcyBsaWtlIHRoZXJlIGlzIG5vIHN1Y2gg InBhbmVsIGhlbHBlciIgZm9yIHRoZSBicmlkZ2UgQVBJIG9yIEkganVzdAo+IGNhbid0IGZpbmQg aXQuCgpZb3UgZG9uJ3QgbmVlZCB0byBnZXQgYSBwYW5lbCBvdXQgb2YgdGhlIGJyaWRnZS4gWW91 IHNob3VsZCBnZXQgdGhlCmJyaWRnZSBhcyBkb25lIHRvZGF5LCBhbmQgd3JhcCBpdCBpbiBhIGJy aWRnZSB3aXRoCmRldm1fZHJtX3BhbmVsX2JyaWRnZV9hZGQoKS4KCi0tIApSZWdhcmRzLAoKTGF1 cmVudCBQaW5jaGFydApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK