All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/selftests: Check power consumption at min/max frequencies
Date: Thu, 16 Apr 2020 23:50:35 +0300	[thread overview]
Message-ID: <20200416205035.GS50947@intel.intel> (raw)
In-Reply-To: <20200416184522.21812-2-chris@chris-wilson.co.uk>

Hi Chris,

> +static u64 __measure_power(int duration_ms)
> +{
> +	u64 nrg, dt;
> +
> +	dt = -ktime_get();
> +	nrg = -st_energy_uJ();
> +	msleep(5);

usleep_range?

Reviewed-by: Andi Shyti <andi.shyti@intel.com>

Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-04-16 20:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 18:45 [Intel-gfx] [PATCH 1/2] drm/i915/selftests: Move gpu energy measurement into its own little lib Chris Wilson
2020-04-16 18:45 ` [Intel-gfx] [PATCH 2/2] drm/i915/selftests: Check power consumption at min/max frequencies Chris Wilson
2020-04-16 20:50   ` Andi Shyti [this message]
2020-04-16 19:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: Move gpu energy measurement into its own little lib Patchwork
2020-04-16 19:34 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-04-16 19:41 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200416205035.GS50947@intel.intel \
    --to=andi.shyti@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.