From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31EC1C2BB85 for ; Fri, 17 Apr 2020 07:10:06 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05F60206D5 for ; Fri, 17 Apr 2020 07:10:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05F60206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id AE5EF8815F; Fri, 17 Apr 2020 07:10:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fIWJD-jdeSO3; Fri, 17 Apr 2020 07:10:05 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 348FC88154; Fri, 17 Apr 2020 07:10:05 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 227A7C089E; Fri, 17 Apr 2020 07:10:05 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6815FC0172 for ; Fri, 17 Apr 2020 07:10:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 58086854E3 for ; Fri, 17 Apr 2020 07:10:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I1tPuMD9HHfH for ; Fri, 17 Apr 2020 07:10:02 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by whitealder.osuosl.org (Postfix) with ESMTPS id BBB7F83204 for ; Fri, 17 Apr 2020 07:10:02 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 12BF968BFE; Fri, 17 Apr 2020 09:09:59 +0200 (CEST) Date: Fri, 17 Apr 2020 09:09:58 +0200 From: Christoph Hellwig To: David Rientjes Subject: Re: [patch 4/7] dma-direct: atomic allocations must come from atomic coherent pools Message-ID: <20200417070958.GB19153@lst.de> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Tom Lendacky , x86@kernel.org, Brijesh Singh , Jon Grimm , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Ingo Molnar , Borislav Petkov , Thomas Gleixner , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" The subject should say something like "atomic unencrypted allocations.." as many other atomic allocations are fine. Which brings up that with the codebase in this patch we can't really support architectures that require both an atomic pool for uncached remapping for just some devices and unencrypted for others. We don't have such an archicture right now, and I hope we don't grow one, but we probably need a little safeguard with a BUILD_BUG_ON if both options are set. I can send an incremental patch for that if that is ok with you. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69DD4C2BB1D for ; Fri, 17 Apr 2020 07:10:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CD4C206D5 for ; Fri, 17 Apr 2020 07:10:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728913AbgDQHKD (ORCPT ); Fri, 17 Apr 2020 03:10:03 -0400 Received: from verein.lst.de ([213.95.11.211]:56051 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728155AbgDQHKD (ORCPT ); Fri, 17 Apr 2020 03:10:03 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 12BF968BFE; Fri, 17 Apr 2020 09:09:59 +0200 (CEST) Date: Fri, 17 Apr 2020 09:09:58 +0200 From: Christoph Hellwig To: David Rientjes Cc: Christoph Hellwig , Tom Lendacky , Brijesh Singh , Jon Grimm , Joerg Roedel , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org Subject: Re: [patch 4/7] dma-direct: atomic allocations must come from atomic coherent pools Message-ID: <20200417070958.GB19153@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The subject should say something like "atomic unencrypted allocations.." as many other atomic allocations are fine. Which brings up that with the codebase in this patch we can't really support architectures that require both an atomic pool for uncached remapping for just some devices and unencrypted for others. We don't have such an archicture right now, and I hope we don't grow one, but we probably need a little safeguard with a BUILD_BUG_ON if both options are set. I can send an incremental patch for that if that is ok with you.