From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13575C2BB1D for ; Fri, 17 Apr 2020 07:34:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8EEC2087E for ; Fri, 17 Apr 2020 07:34:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587108869; bh=X6tskjtkbbD7eJmw+HYMlmuZZqatAbez8A/OwFmPCxw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ejx/qQPKvcRhVyTv2RBS9Ek77G2nrLBfcR8i7w+phRmICc2B3FldVMwuIxLCppj/y CF3LKX/fvCSOmf8ed0If8sHaeZ8mjD2BSn+h5YGMaDP29wQupX7Pf38TGgdULcegqX MiwIrH0fK9DdrJ3QBJaW3nxzDBWVw/UCVsD1GvfI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729004AbgDQHe3 (ORCPT ); Fri, 17 Apr 2020 03:34:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:39674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728419AbgDQHe3 (ORCPT ); Fri, 17 Apr 2020 03:34:29 -0400 Received: from coco.lan (ip5f5ad4d8.dynamic.kabel-deutschland.de [95.90.212.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A3B392054F; Fri, 17 Apr 2020 07:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587108868; bh=X6tskjtkbbD7eJmw+HYMlmuZZqatAbez8A/OwFmPCxw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CCAtm1P4qw2uv0uq82hOsfGayDbjL0JRne/7ux68afyxJNqOhi/sd4pQsTWPWyzUT DZT4djebQTcYFbpttIndRig2r2T8WRKpbkQHUe5rs3AwBP0k9EozeJ2kfcOhhHQgUJ JMzjQUMdAQE70glUdeLHkOfZCwVYSvgF82pEYP/0= Date: Fri, 17 Apr 2020 09:34:24 +0200 From: Mauro Carvalho Chehab To: Geert Uytterhoeven Cc: Linux Media Mailing List , Hans Verkuil Subject: Re: [PATCH 1/3] media: cec: don't select PCI & DMI Message-ID: <20200417093424.71ae0559@coco.lan> In-Reply-To: References: <6af5797c76c11d8c08ae1f5a73c3711fcf89ab6f.1587107273.git.mchehab+huawei@kernel.org> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Fri, 17 Apr 2020 09:30:51 +0200 Geert Uytterhoeven escreveu: > Hi Mauro, > > On Fri, Apr 17, 2020 at 9:08 AM Mauro Carvalho Chehab > wrote: > > While select would be a great idea for most archs, this > > causes a breakage with s390: > > > > "I don't think that's a good idea, as it suddenly enables selecting all PCI > > drivers on platforms that do not have PCI. > > > > WARNING: unmet direct dependencies detected for PCI > > Depends on [n]: HAVE_PCI [=n] > > Selected by [m]: > > - CEC_SECO [=m] && MEDIA_CEC_SUPPORT [=y] && (X86 || IA64 || COMPILE_TEST [=y]) > > > > Reported-by: Geert Uytterhoeven > > Signed-off-by: Mauro Carvalho Chehab > > Thanks for your patch! > > Fixes: 4be5e8648b0c287a ("media: move CEC platform drivers to a > separate directory") > Acked-by: Geert Uytterhoeven Btw, I almost solved it on a different way, keeping the select and making it depends on HAVE_PCI. I ended by opting to do this change in order to try to avoid more Kconfig noise (and because "select PCI" is not popular those days). Thanks, Mauro