From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E531C2D0EF for ; Fri, 17 Apr 2020 13:03:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49401206A2 for ; Fri, 17 Apr 2020 13:03:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XrtQxiqM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49401206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tf2pk1CHwfwlrwba5H8HA4jUSlm0tqQaw73QZFFf5uE=; b=XrtQxiqMwGQy8q OsjgmgBRqv6nj0YNjg3stLDPiur8/SSTo2Zhsx+EqMkgLLzLid3rN7rDALBNbTaH0MUXpoULD7dhQ yA38lFNiRqk1hlU44e89M5UIDzXx5hblA0mBYdq5Z1Lo0PF4ppT8JTug0awXXLTnqkGZQWPiHH41E UXDAa+CY55iMhwiiZyScRtJLp5ARFBDLgo2snIlLqn5T4IAm9BO+2Hi1uZy970Ze++pgcf/KTCd6L yaTa2dzd/S2ogw+K/lv4pXmS79KO4v/B7GzaL7cvMG9bK9OM/nYgYd/5ef4thT9XFQDy/VEGX/iT4 fHw8APSS5kuRbdcP1YxA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPQeA-0000ar-E1; Fri, 17 Apr 2020 13:03:06 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jPQch-00032y-Tu for linux-nvme@lists.infradead.org; Fri, 17 Apr 2020 13:01:38 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id A72B768BEB; Fri, 17 Apr 2020 14:59:29 +0200 (CEST) Date: Fri, 17 Apr 2020 14:59:29 +0200 From: Christoph Hellwig To: Kai-Heng Feng Subject: Re: [PATCH] nvme/pci: Use Discard instead of Write Zeroes on SK hynix SC300 Message-ID: <20200417125929.GA5053@lst.de> References: <20200417083641.28205-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200417083641.28205-1-kai.heng.feng@canonical.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200417_060136_125860_006DE414 X-CRM114-Status: UNSURE ( 7.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sagi@grimberg.me, open list , "open list:NVM EXPRESS DRIVER" , axboe@fb.com, linux-stable , kbusch@kernel.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Apr 17, 2020 at 04:36:41PM +0800, Kai-Heng Feng wrote: > After commit 6e02318eaea5 ("nvme: add support for the Write Zeroes > command"), SK hynix SC300 becomes very slow with the following error > message: > [ 224.567695] blk_update_request: operation not supported error, dev nvme1n1, sector 499384320 op 0x9:(WRITE_ZEROES) flags 0x1000000 phys_seg 0 prio class 0] > > Use quirk NVME_QUIRK_DEALLOCATE_ZEROES to workaround this issue. Do you have a written guarantee from SK Hynix that it will always zero all blocks discarded? _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 406D0C38A2B for ; Fri, 17 Apr 2020 12:59:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A72C206A2 for ; Fri, 17 Apr 2020 12:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730649AbgDQM7e (ORCPT ); Fri, 17 Apr 2020 08:59:34 -0400 Received: from verein.lst.de ([213.95.11.211]:57514 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730166AbgDQM7c (ORCPT ); Fri, 17 Apr 2020 08:59:32 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id A72B768BEB; Fri, 17 Apr 2020 14:59:29 +0200 (CEST) Date: Fri, 17 Apr 2020 14:59:29 +0200 From: Christoph Hellwig To: Kai-Heng Feng Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-stable , "open list:NVM EXPRESS DRIVER" , open list Subject: Re: [PATCH] nvme/pci: Use Discard instead of Write Zeroes on SK hynix SC300 Message-ID: <20200417125929.GA5053@lst.de> References: <20200417083641.28205-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200417083641.28205-1-kai.heng.feng@canonical.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 17, 2020 at 04:36:41PM +0800, Kai-Heng Feng wrote: > After commit 6e02318eaea5 ("nvme: add support for the Write Zeroes > command"), SK hynix SC300 becomes very slow with the following error > message: > [ 224.567695] blk_update_request: operation not supported error, dev nvme1n1, sector 499384320 op 0x9:(WRITE_ZEROES) flags 0x1000000 phys_seg 0 prio class 0] > > Use quirk NVME_QUIRK_DEALLOCATE_ZEROES to workaround this issue. Do you have a written guarantee from SK Hynix that it will always zero all blocks discarded?