From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34A11C352BE for ; Fri, 17 Apr 2020 11:10:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08B7B221EA for ; Fri, 17 Apr 2020 11:10:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587121859; bh=tCQquf491poUngMRJaQnlMBZ2MoJzib0aId2SU4OoXQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=rbGu7FykVDooFgYrWZT0CYc9W8h7c836+mj0ZenNKvSCjdEJL1KeMNU9qQ9IqsCDL dvEC1AMadJ/zF5n1zozQE64/uTPCx5ARy/xKQm7Dh3K+V2JQej4qaRdgu1tn36Pj1i tJ8aSqvRguuBHbORlOlhtZqxu1um3q1N0IhmcmBE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730208AbgDQLK6 (ORCPT ); Fri, 17 Apr 2020 07:10:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:39546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730168AbgDQLK6 (ORCPT ); Fri, 17 Apr 2020 07:10:58 -0400 Received: from coco.lan (ip5f5ad4d8.dynamic.kabel-deutschland.de [95.90.212.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 99ED321D95; Fri, 17 Apr 2020 11:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587121857; bh=tCQquf491poUngMRJaQnlMBZ2MoJzib0aId2SU4OoXQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2qpVqwL8UoxPk8oVmTt/ZQPjci/evr9BGLIMrPaChIMdyjS39CpYENNo9AGhM9wWu scXrQUC32D/Rk3PEJ4y3W9GfkUiO9IhRmL2U9ShLoSgxiFXMCXuU8MSfDuE74OSa7j CHMNHtqP9yhKkFE0mCCKzg+XJYvV3EwBMyJlFLJ8= Date: Fri, 17 Apr 2020 13:10:53 +0200 From: Mauro Carvalho Chehab To: Geert Uytterhoeven Cc: Linux Media Mailing List , Hans Verkuil Subject: Re: [PATCH 1/3] media: cec: don't select PCI & DMI Message-ID: <20200417131053.3cf1b86a@coco.lan> In-Reply-To: References: <6af5797c76c11d8c08ae1f5a73c3711fcf89ab6f.1587107273.git.mchehab+huawei@kernel.org> <20200417093424.71ae0559@coco.lan> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Fri, 17 Apr 2020 09:52:02 +0200 Geert Uytterhoeven escreveu: > Hi Mauro, > > On Fri, Apr 17, 2020 at 9:34 AM Mauro Carvalho Chehab > wrote: > > Em Fri, 17 Apr 2020 09:30:51 +0200 > > Geert Uytterhoeven escreveu: > > > On Fri, Apr 17, 2020 at 9:08 AM Mauro Carvalho Chehab > > > wrote: > > > > While select would be a great idea for most archs, this > > > > causes a breakage with s390: > > > > > > > > "I don't think that's a good idea, as it suddenly enables selecting all PCI > > > > drivers on platforms that do not have PCI. > > > > > > > > WARNING: unmet direct dependencies detected for PCI > > > > Depends on [n]: HAVE_PCI [=n] > > > > Selected by [m]: > > > > - CEC_SECO [=m] && MEDIA_CEC_SUPPORT [=y] && (X86 || IA64 || COMPILE_TEST [=y]) > > > > > > > > Reported-by: Geert Uytterhoeven > > > > Signed-off-by: Mauro Carvalho Chehab > > > > > > Thanks for your patch! > > > > > > Fixes: 4be5e8648b0c287a ("media: move CEC platform drivers to a > > > separate directory") > > > Acked-by: Geert Uytterhoeven > > > > Btw, I almost solved it on a different way, keeping the select and making > > it depends on HAVE_PCI. > > Like you did for the similar change to USB? Yes. The thing is: there are several other drivers that already select USB (and one driver selecting USB_ACM). So, this didn't sound too risky. On the other hand, there's currently nothing selecting "PCI". So, in order to avoid more (possible) Kconfig noise, I opted to be more conservative here. Thanks, Mauro