All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
	fio@vger.kernel.org, Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH v2] zbd: Fix I/O direction adjustment step for random read/write
Date: Fri, 17 Apr 2020 20:30:50 +0300	[thread overview]
Message-ID: <20200417173050.GA26921@avx2> (raw)
In-Reply-To: <8acaca2e-d5dc-e091-6579-ebb5e6a55c3b@kernel.dk>

On Fri, Apr 17, 2020 at 08:32:05AM -0600, Jens Axboe wrote:
> I'm not a huge fan of this zbd sprinkling everywhere, but that's not the
> fault of your fix. But I would really prefer if zbd got disentangled
> from the core/hot paths completely, maybe by adding a io engine fn for
> whatever it needs to do.

I think it should be done at generator level. zonemode=strided/zbd is
really a specialized random generator. Such generator would issue first
write in ZBD mode and read/write in normal mode.

zbd_adjust_block() is strange. For example "norandommap" in ZBD mode
doesn't guarantee full LBA space coverage even with 1 thread but it
would guarantee it with 1 thread and generator which shuffles zone
numbers once and issues writes with any QD.

But the combinatorial explosion given the number of options scaries me.
And then things will become even more entertaining once QD > 1 zone appends
start to show up!


  reply	other threads:[~2020-04-17 17:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 11:30 [PATCH v2] zbd: Fix I/O direction adjustment step for random read/write Shin'ichiro Kawasaki
2020-04-17  4:58 ` Damien Le Moal
2020-04-17 14:32 ` Jens Axboe
2020-04-17 17:30   ` Alexey Dobriyan [this message]
2020-04-20  2:41     ` Damien Le Moal
2020-04-20 18:10       ` Alexey Dobriyan
2020-04-20  2:33   ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200417173050.GA26921@avx2 \
    --to=adobriyan@gmail.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=fio@vger.kernel.org \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.