From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Fri, 17 Apr 2020 20:29:07 +0000 Subject: Re: [PATCH 6/8] drm: decouple from CONFIG_FB Message-Id: <20200417202907.GA5617@ravnborg.org> List-Id: References: <20200417155553.675905-1-arnd@arndb.de> <20200417155553.675905-7-arnd@arndb.de> <20200417165041.GA30483@ravnborg.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Arnd Bergmann , Daniel Vetter Cc: Marek Vasut , Linux-Renesas , Linux Fbdev development list , dsd@laptop.org, Nicolas Pitre , David Airlie , Masahiro Yamada , jfrederich@gmail.com, Saeed Mahameed , Thomas Hellstrom , Haojian Zhuang , Andrzej Hajda , Kieran Bingham , Geert Uytterhoeven , dri-devel , VMware Graphics , Robert Jarzmik , Jason Gunthorpe , Daniel Mack , Laurent Pinchart Hi Arnd. On Fri, Apr 17, 2020 at 10:03:23PM +0200, Arnd Bergmann wrote: > On Fri, Apr 17, 2020 at 6:50 PM Sam Ravnborg wrote: > > > > > So what this try to say is that we cannot have FB a module while DRM is > > built-in (marked N in the above). > > Correct > > > > > Could you explain in the changelog why this combination is not good. > > (Or tell me if my analysis was flawed). > > I agree in hindsight this was less obvious than I thought ;-) > > Added this text to the changelog: > > | When CONFIG_FB is a loadable module, DRM_KMS_FB_HELPER cannot be > | part of the built-in subsystem, so add dependency to ensure this > | can only be enabled if the DRM module can successfully be linked. > > and this comment in the Kconfig file: > > @@ -112,7 +112,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM && FB > - depends on FB=y || DRM=m > + depends on FB=y || DRM=m # DRM_KMS_FB_HELPER links against FB > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > default y > > Let me know if you think those changes are sufficient > > > With this fixed (assuming I am right): > > Reviewed-by: Sam Ravnborg Yes, that explains it nicely - thanks. But unless Daniel decides otherwise we do not get it applied. He was not too happy with it. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5FEEC38A2B for ; Fri, 17 Apr 2020 20:29:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFCB0221E9 for ; Fri, 17 Apr 2020 20:29:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730937AbgDQU3V (ORCPT ); Fri, 17 Apr 2020 16:29:21 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:44894 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730903AbgDQU3V (ORCPT ); Fri, 17 Apr 2020 16:29:21 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id B8B1080528; Fri, 17 Apr 2020 22:29:13 +0200 (CEST) Date: Fri, 17 Apr 2020 22:29:07 +0200 From: Sam Ravnborg To: Arnd Bergmann , Daniel Vetter Cc: dri-devel , Jani Nikula , Linux Fbdev development list , Marek Vasut , dsd@laptop.org, Andrzej Hajda , David Airlie , Masahiro Yamada , Nicolas Pitre , Saeed Mahameed , Thomas Hellstrom , Haojian Zhuang , Geert Uytterhoeven , Linux-Renesas , Jason Gunthorpe , Kieran Bingham , VMware Graphics , Laurent Pinchart , jfrederich@gmail.com, Robert Jarzmik , Daniel Mack Subject: Re: [PATCH 6/8] drm: decouple from CONFIG_FB Message-ID: <20200417202907.GA5617@ravnborg.org> References: <20200417155553.675905-1-arnd@arndb.de> <20200417155553.675905-7-arnd@arndb.de> <20200417165041.GA30483@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=r6ubUnnpiWzmGfokuToA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Arnd. On Fri, Apr 17, 2020 at 10:03:23PM +0200, Arnd Bergmann wrote: > On Fri, Apr 17, 2020 at 6:50 PM Sam Ravnborg wrote: > > > > > So what this try to say is that we cannot have FB a module while DRM is > > built-in (marked N in the above). > > Correct > > > > > Could you explain in the changelog why this combination is not good. > > (Or tell me if my analysis was flawed). > > I agree in hindsight this was less obvious than I thought ;-) > > Added this text to the changelog: > > | When CONFIG_FB is a loadable module, DRM_KMS_FB_HELPER cannot be > | part of the built-in subsystem, so add dependency to ensure this > | can only be enabled if the DRM module can successfully be linked. > > and this comment in the Kconfig file: > > @@ -112,7 +112,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM && FB > - depends on FB=y || DRM=m > + depends on FB=y || DRM=m # DRM_KMS_FB_HELPER links against FB > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > default y > > Let me know if you think those changes are sufficient > > > With this fixed (assuming I am right): > > Reviewed-by: Sam Ravnborg Yes, that explains it nicely - thanks. But unless Daniel decides otherwise we do not get it applied. He was not too happy with it. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9362C38A2C for ; Fri, 17 Apr 2020 20:29:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99C94221E9 for ; Fri, 17 Apr 2020 20:29:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99C94221E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EEFAE6EA90; Fri, 17 Apr 2020 20:29:21 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 396DF6EA63 for ; Fri, 17 Apr 2020 20:29:20 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id B8B1080528; Fri, 17 Apr 2020 22:29:13 +0200 (CEST) Date: Fri, 17 Apr 2020 22:29:07 +0200 From: Sam Ravnborg To: Arnd Bergmann , Daniel Vetter Subject: Re: [PATCH 6/8] drm: decouple from CONFIG_FB Message-ID: <20200417202907.GA5617@ravnborg.org> References: <20200417155553.675905-1-arnd@arndb.de> <20200417155553.675905-7-arnd@arndb.de> <20200417165041.GA30483@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=XpTUx2N9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=r6ubUnnpiWzmGfokuToA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Linux-Renesas , Linux Fbdev development list , dsd@laptop.org, Nicolas Pitre , David Airlie , Masahiro Yamada , jfrederich@gmail.com, Saeed Mahameed , Thomas Hellstrom , Haojian Zhuang , Andrzej Hajda , Kieran Bingham , Geert Uytterhoeven , dri-devel , VMware Graphics , Robert Jarzmik , Jason Gunthorpe , Daniel Mack , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Arnd. On Fri, Apr 17, 2020 at 10:03:23PM +0200, Arnd Bergmann wrote: > On Fri, Apr 17, 2020 at 6:50 PM Sam Ravnborg wrote: > > > > > So what this try to say is that we cannot have FB a module while DRM is > > built-in (marked N in the above). > > Correct > > > > > Could you explain in the changelog why this combination is not good. > > (Or tell me if my analysis was flawed). > > I agree in hindsight this was less obvious than I thought ;-) > > Added this text to the changelog: > > | When CONFIG_FB is a loadable module, DRM_KMS_FB_HELPER cannot be > | part of the built-in subsystem, so add dependency to ensure this > | can only be enabled if the DRM module can successfully be linked. > > and this comment in the Kconfig file: > > @@ -112,7 +112,7 @@ config DRM_DEBUG_DP_MST_TOPOLOGY_REFS > config DRM_FBDEV_EMULATION > bool "Enable legacy fbdev support for your modesetting driver" > depends on DRM && FB > - depends on FB=y || DRM=m > + depends on FB=y || DRM=m # DRM_KMS_FB_HELPER links against FB > select DRM_KMS_HELPER > select DRM_KMS_FB_HELPER > default y > > Let me know if you think those changes are sufficient > > > With this fixed (assuming I am right): > > Reviewed-by: Sam Ravnborg Yes, that explains it nicely - thanks. But unless Daniel decides otherwise we do not get it applied. He was not too happy with it. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel