All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "lars@engebretsen.ch" <lars@engebretsen.ch>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v2] iio: core: remove extra semi-colon from devm_iio_device_register() macro
Date: Sat, 18 Apr 2020 17:13:48 +0100	[thread overview]
Message-ID: <20200418171348.72f9d032@archlinux> (raw)
In-Reply-To: <526f58cee9ef50cfb13af4b25d215735985cce9a.camel@analog.com>

On Wed, 15 Apr 2020 11:41:24 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Wed, 2020-04-15 at 12:10 +0200, Lars Engebretsen wrote:
> > This change removes the semi-colon from the devm_iio_device_register()
> > macro which seems to have been added by accident via commit 63b19547cc3d9
> > ("iio: Use macro magic to avoid manual assign of driver_module").
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

The above reference to where the bug was introduced should have been
a Fixes: tag as that guides where this is backported to.

I made it so whilst applying.

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> 
> > Signed-off-by: Lars Engebretsen <lars@engebretsen.ch>
> > ---
> > Changelog v1 -> v2:
> > * added commit change description
> > 
> >  include/linux/iio/iio.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> > index d63884a54939..76ba7c9fd3e0 100644
> > --- a/include/linux/iio/iio.h
> > +++ b/include/linux/iio/iio.h
> > @@ -597,7 +597,7 @@ void iio_device_unregister(struct iio_dev *indio_dev);
> >   * 0 on success, negative error number on failure.
> >   */
> >  #define devm_iio_device_register(dev, indio_dev) \
> > -	__devm_iio_device_register((dev), (indio_dev), THIS_MODULE);
> > +	__devm_iio_device_register((dev), (indio_dev), THIS_MODULE)
> >  int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev,
> >  			       struct module *this_mod);
> >  int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);  


      reply	other threads:[~2020-04-18 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 10:10 [PATCH v2] iio: core: remove extra semi-colon from devm_iio_device_register() macro Lars Engebretsen
2020-04-15 11:41 ` Ardelean, Alexandru
2020-04-18 16:13   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200418171348.72f9d032@archlinux \
    --to=jic23@kernel.org \
    --cc=alexandru.Ardelean@analog.com \
    --cc=lars@engebretsen.ch \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.