All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: gregkh@linuxfoundation.org, tglx@linutronix.de, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] posix-cpu-timers: Store a reference to a pid not a task" failed to apply to 5.6-stable tree
Date: Sat, 18 Apr 2020 13:38:41 -0400	[thread overview]
Message-ID: <20200418173841.GD1809@sasha-vm> (raw)
In-Reply-To: <20200418160513.GB1809@sasha-vm>

On Sat, Apr 18, 2020 at 12:05:13PM -0400, Sasha Levin wrote:
>On Sat, Apr 18, 2020 at 07:37:08AM -0500, Eric W. Biederman wrote:
>><gregkh@linuxfoundation.org> writes:
>>
>>>The patch below does not apply to the 5.6-stable tree.
>>>If someone wants it applied there, or to any other stable or longterm
>>>tree, then please email the backport, including the original git commit
>>>id to <stable@vger.kernel.org>.
>>
>>So for anyone who cares the fix I refer to in the commit comment is the
>>workaround that keeps the past implementation from being a real problem.
>>
>>I just see this as code cleanup so I can remove the old workaround.  The
>>old workaround will cause posix_cpu_timers_exit_group to be called early
>>on particular variants of multi-threaded exec, resulting in the
>>corresponding cpu clock stopping.  So this does represent a real fix.
>>
>>However using a cpu timer of another process to signal things in your
>>process is rare, and the case is breaks is only in certain obscure
>>variations of a multi-threaded exec.  Further no one has to my knowledge
>>complained in over a decade.
>>
>>If someone sees that fix as important, and something that needs to be
>>backported, it will be easiest to backport my earlier cleanup patches
>>in the same series.
>
>For 5.6, 5.5, and 5.4 it was enough to take:
>
>	60f2ceaa8111 ("posix-cpu-timers: Remove unnecessary locking around cpu_clock_sample_group")
>
>as a dependency. Based on the commit message there it should be safe so
>I did just that.

Ignore that, I've dropped it for now.

-- 
Thanks,
Sasha

  reply	other threads:[~2020-04-18 17:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-18 10:21 FAILED: patch "[PATCH] posix-cpu-timers: Store a reference to a pid not a task" failed to apply to 5.6-stable tree gregkh
2020-04-18 12:37 ` Eric W. Biederman
2020-04-18 16:05   ` Sasha Levin
2020-04-18 17:38     ` Sasha Levin [this message]
2020-04-19  5:50       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200418173841.GD1809@sasha-vm \
    --to=sashal@kernel.org \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.