From: Kunal Joshi <kunal1.joshi@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2] tests/kms_chamelium: Capture on type-c
Date: Mon, 20 Apr 2020 06:32:27 +0530 [thread overview]
Message-ID: <20200420010227.GA12778@intel.com> (raw)
In-Reply-To: <20200420075512.ehv5w2yiikymql5h@ahiler-desk1.fi.intel.com>
On 2020-04-20 at 10:55:12 +0300, Arkadiusz Hiler wrote:
> On Mon, Apr 20, 2020 at 02:56:13AM +0530, Kunal Joshi wrote:
> > Refreshing the connector everytime and also resetting the
> > state to get HPD reliably.
>
> Code looks good, but please consider adding a bit more of explanation
> here, something like:
>
> Chamelium uses HPD pulses to singal the need for a receiver reset using
> DPMS cycle. Some connectors (e.g. DP over TypeC) have limitations and
> will receive just a single such pulse and discard the rest. This lasts
> until we disable the mode completetly and only then reenable it.
>
> Receiver reset is always required after we set a new mode, so let's
> disable the mode (reset_state() does that) before we switch to a new
> mode. With this we will get the HPD pulses reliably for each iteration
> over all the supoprted modes.
>
> There are alse targeted test for HPD pulse handling - dp-hpd-*.
>
Yes arek will add this explanation in the commit keeping your rb
Thanks Kunal.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-04-20 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 21:26 [igt-dev] [PATCH i-g-t v2] tests/kms_chamelium: Capture on type-c Kunal Joshi
2020-04-20 5:16 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium: Capture on type-c (rev2) Patchwork
2020-04-20 7:55 ` [igt-dev] [PATCH i-g-t v2] tests/kms_chamelium: Capture on type-c Arkadiusz Hiler
2020-04-20 1:02 ` Kunal Joshi [this message]
2020-04-20 10:24 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_chamelium: Capture on type-c (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420010227.GA12778@intel.com \
--to=kunal1.joshi@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.