From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A0BC54FD0 for ; Mon, 20 Apr 2020 07:27:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5864A20BED for ; Mon, 20 Apr 2020 07:27:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zjs6lkCZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726136AbgDTH1c (ORCPT ); Mon, 20 Apr 2020 03:27:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726116AbgDTH1c (ORCPT ); Mon, 20 Apr 2020 03:27:32 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B35E2C061A41 for ; Mon, 20 Apr 2020 00:27:31 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id k11so10790201wrp.5 for ; Mon, 20 Apr 2020 00:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fLd3utKBUqircZ8XSU/jqQ1o3HOdiOgb+Til4epkr7E=; b=Zjs6lkCZP51RU1eaQIhcoO3FB2Z6jXmILC0s2D752dm7NvsQ+tleMbs3JgJ0uCOger E/tjxVQyBlWGd8C8KH6qKSy877jK0dOi4ouglmI3EUeSGLveLxJsg2RtwSK7UMdZjCHW wFmMR6P5iaO2QXH4ksbOgvB+J3KLMVx+AA8FAPieKGTfyyESTZnp60vvRq2mOL1n6k89 exxFo80LcTgKlrntlkSIIORBACYyTzHdDPArnuLiOwJFPLXem/gn0Igo6JBXWNAODiUe tLRv8q8+adw+2X8p6HhK3S5Eako2xzmyRKxo0WGwjta/t8GubKM8ali0sa3m5En/fezW 12VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fLd3utKBUqircZ8XSU/jqQ1o3HOdiOgb+Til4epkr7E=; b=ah8/rfzifZHlmd3woU2YQ2iPnQzd+/9cImvmVjD+d1Mo416iv1pGnoGdTvyUldomsS SZmySoklb54PgwOP9IRB0h3k24IM6fF7eBxkornya1nRsR4KEneNbZnhO0crqK2k/+4Q GCJZ6DZXjYV+G+SThDpYLvjDPxlSf4MiMq1o04Ongq3ouvbQQOkvoTXcCtzXojF2HBcn rWJFjTKaebAF8hSjxP8nUZFmaiuuCLef16Dh20kgg3ONhnIZxoDq5Q/k0moN0neUR/SZ MUl5J6fOoymCuFaKFH3wI9p7GjcEVv0gbLswQrEtIp+aGSzYJtlcqGT/8j8hs5zKih1b zZig== X-Gm-Message-State: AGi0PuZosNiOT8mUghBeK3PVsAdOpkd1nGOpg1sF9aHEL8DNF7nmFZ2x akMgsXteFZ2NIA5be4l+aotXNA== X-Google-Smtp-Source: APiQypLZ95duN0TVR/SeVUQItXdNoeinc7W1AvPfKzE2PNLYi2bchw8ulFVhIRvX/oUlL+29V+w4Lg== X-Received: by 2002:a5d:5224:: with SMTP id i4mr17175368wra.1.1587367650264; Mon, 20 Apr 2020 00:27:30 -0700 (PDT) Received: from dell ([95.149.164.107]) by smtp.gmail.com with ESMTPSA id v16sm188543wml.30.2020.04.20.00.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 00:27:29 -0700 (PDT) Date: Mon, 20 Apr 2020 08:27:27 +0100 From: Lee Jones To: kgunda@codeaurora.org Cc: Rob Herring , bjorn.andersson@linaro.org, jingoohan1@gmail.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, daniel.thompson@linaro.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, mark.rutland@arm.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Murphy , linux-arm-msm@vger.kernel.org, Subbaraman Narayanamurthy Subject: Re: [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format Message-ID: <20200420072727.GI3737@dell> References: <1586274430-28402-1-git-send-email-kgunda@codeaurora.org> <1586274430-28402-2-git-send-email-kgunda@codeaurora.org> <20200415150904.GA11174@bogus> <557e8bd874256271174402b5faba9c90@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <557e8bd874256271174402b5faba9c90@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 17 Apr 2020, kgunda@codeaurora.org wrote: > On 2020-04-15 20:39, Rob Herring wrote: > > On Tue, Apr 07, 2020 at 09:17:07PM +0530, Kiran Gunda wrote: > > > Convert the qcom-wled bindings from .txt to .yaml format. > > > Also replace PM8941 to WLED3 and PMI8998 to WLED4. > > > > > > Signed-off-by: Kiran Gunda > > > Signed-off-by: Subbaraman Narayanamurthy > > > Acked-by: Daniel Thompson > > > --- > > > .../bindings/leds/backlight/qcom-wled.txt | 154 > > > ---------------- > > > .../bindings/leds/backlight/qcom-wled.yaml | 201 > > > +++++++++++++++++++++ > > > 2 files changed, 201 insertions(+), 154 deletions(-) > > > delete mode 100644 > > > Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt > > > create mode 100644 > > > Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml [...] > > > + interrupt-names: > > > + items: > > > + - const: ovp > > > + - const: short > > > > Move these 2 props to the main section adding a 'minItems: 1'. Then just > > define 'minItems: 2' here and 'maxItems: 1' in the 'then' clause. > > > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - label > > > > Add: > > > > additionalProperties: false > > > > > + > > > +examples: > > > + - | > > > + backlight@d800 { > > > + compatible = "qcom,pm8941-wled"; > > > + reg = <0xd800 0x100>; > > > + label = "backlight"; > > > + > > > + qcom,cs-out; > > > + qcom,current-limit = <20>; > > > + qcom,current-boost-limit = <805>; > > > + qcom,switching-freq = <1600>; > > > + qcom,ovp = <29>; > > > + qcom,num-strings = <2>; > > > + qcom,enabled-strings = <0 1>; > > > + }; > Thanks for reviewing. I will submit the next revision with all the fixes. Please trim your replies. Also, if you agree with all of the review comments, there really is no need to reply and/or thank the reviewer. Simply submit a subsequent set with a bumped version indicator. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0B1AC3815B for ; Mon, 20 Apr 2020 07:27:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2F9D2080C for ; Mon, 20 Apr 2020 07:27:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zjs6lkCZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2F9D2080C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DFE06E26C; Mon, 20 Apr 2020 07:27:32 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id A7D7A6E26C for ; Mon, 20 Apr 2020 07:27:31 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id g13so8750632wrb.8 for ; Mon, 20 Apr 2020 00:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fLd3utKBUqircZ8XSU/jqQ1o3HOdiOgb+Til4epkr7E=; b=Zjs6lkCZP51RU1eaQIhcoO3FB2Z6jXmILC0s2D752dm7NvsQ+tleMbs3JgJ0uCOger E/tjxVQyBlWGd8C8KH6qKSy877jK0dOi4ouglmI3EUeSGLveLxJsg2RtwSK7UMdZjCHW wFmMR6P5iaO2QXH4ksbOgvB+J3KLMVx+AA8FAPieKGTfyyESTZnp60vvRq2mOL1n6k89 exxFo80LcTgKlrntlkSIIORBACYyTzHdDPArnuLiOwJFPLXem/gn0Igo6JBXWNAODiUe tLRv8q8+adw+2X8p6HhK3S5Eako2xzmyRKxo0WGwjta/t8GubKM8ali0sa3m5En/fezW 12VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fLd3utKBUqircZ8XSU/jqQ1o3HOdiOgb+Til4epkr7E=; b=m/qW+UhFvnN1nzVBw/ePIfzxmm6EwF2kFbnTf0w0Fy/Rljxu36PDncR+hNYuRcNxhu jSj4b09youbrnG1sEyxkElMJLUR9JHz19cGdo1iJNFQ0IINf5FoAMrDey1D+uPnu8W88 0S1c8M7PAVGrIIj/MXmMtAKiyyzPk6lrqc1YjFUdhbONbaG04huVkgXY1pMNgKnn9UAd iVHKADUo3AfwzeTBvGYPjaib462VobQ2Q+PvZOH4387/rq27nbU3kA4KbS/ofjtwTLSo ffZx+q/BBbcyxLps7pMdchLlUy5Hp7Gif+qcLP3JVmgiNT8g/hZgFDtuJlaPKB5NK4Ad PvWQ== X-Gm-Message-State: AGi0PuYAXcuuEVdJR/rQBstDU3wmti6BwL6HuoceX1jgX3y5kLu8Ubw/ kp43km3SO2DDw2wIN/QvFAYDbw== X-Google-Smtp-Source: APiQypLZ95duN0TVR/SeVUQItXdNoeinc7W1AvPfKzE2PNLYi2bchw8ulFVhIRvX/oUlL+29V+w4Lg== X-Received: by 2002:a5d:5224:: with SMTP id i4mr17175368wra.1.1587367650264; Mon, 20 Apr 2020 00:27:30 -0700 (PDT) Received: from dell ([95.149.164.107]) by smtp.gmail.com with ESMTPSA id v16sm188543wml.30.2020.04.20.00.27.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2020 00:27:29 -0700 (PDT) Date: Mon, 20 Apr 2020 08:27:27 +0100 From: Lee Jones To: kgunda@codeaurora.org Subject: Re: [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format Message-ID: <20200420072727.GI3737@dell> References: <1586274430-28402-1-git-send-email-kgunda@codeaurora.org> <1586274430-28402-2-git-send-email-kgunda@codeaurora.org> <20200415150904.GA11174@bogus> <557e8bd874256271174402b5faba9c90@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <557e8bd874256271174402b5faba9c90@codeaurora.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, daniel.thompson@linaro.org, b.zolnierkie@samsung.com, jingoohan1@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, linux-arm-msm@vger.kernel.org, Subbaraman Narayanamurthy , linux-leds@vger.kernel.org, Dan Murphy Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCAxNyBBcHIgMjAyMCwga2d1bmRhQGNvZGVhdXJvcmEub3JnIHdyb3RlOgoKPiBPbiAy MDIwLTA0LTE1IDIwOjM5LCBSb2IgSGVycmluZyB3cm90ZToKPiA+IE9uIFR1ZSwgQXByIDA3LCAy MDIwIGF0IDA5OjE3OjA3UE0gKzA1MzAsIEtpcmFuIEd1bmRhIHdyb3RlOgo+ID4gPiBDb252ZXJ0 IHRoZSBxY29tLXdsZWQgYmluZGluZ3MgZnJvbSAudHh0IHRvIC55YW1sIGZvcm1hdC4KPiA+ID4g QWxzbyByZXBsYWNlIFBNODk0MSB0byBXTEVEMyBhbmQgUE1JODk5OCB0byBXTEVENC4KPiA+ID4g Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEtpcmFuIEd1bmRhIDxrZ3VuZGFAY29kZWF1cm9yYS5vcmc+ Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFN1YmJhcmFtYW4gTmFyYXlhbmFtdXJ0aHkgPHN1YmJhcmFt QGNvZGVhdXJvcmEub3JnPgo+ID4gPiBBY2tlZC1ieTogRGFuaWVsIFRob21wc29uIDxkYW5pZWwu dGhvbXBzb25AbGluYXJvLm9yZz4KPiA+ID4gLS0tCj4gPiA+ICAuLi4vYmluZGluZ3MvbGVkcy9i YWNrbGlnaHQvcWNvbS13bGVkLnR4dCAgICAgICAgICB8IDE1NAo+ID4gPiAtLS0tLS0tLS0tLS0t LS0tCj4gPiA+ICAuLi4vYmluZGluZ3MvbGVkcy9iYWNrbGlnaHQvcWNvbS13bGVkLnlhbWwgICAg ICAgICB8IDIwMQo+ID4gPiArKysrKysrKysrKysrKysrKysrKysKPiA+ID4gIDIgZmlsZXMgY2hh bmdlZCwgMjAxIGluc2VydGlvbnMoKyksIDE1NCBkZWxldGlvbnMoLSkKPiA+ID4gIGRlbGV0ZSBt b2RlIDEwMDY0NAo+ID4gPiBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbGVkcy9i YWNrbGlnaHQvcWNvbS13bGVkLnR4dAo+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0Cj4gPiA+IERv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9sZWRzL2JhY2tsaWdodC9xY29tLXdsZWQu eWFtbApbLi4uXQoKPiA+ID4gKyAgICAgICAgaW50ZXJydXB0LW5hbWVzOgo+ID4gPiArICAgICAg ICAgIGl0ZW1zOgo+ID4gPiArICAgICAgICAgICAgLSBjb25zdDogb3ZwCj4gPiA+ICsgICAgICAg ICAgICAtIGNvbnN0OiBzaG9ydAo+ID4gCj4gPiBNb3ZlIHRoZXNlIDIgcHJvcHMgdG8gdGhlIG1h aW4gc2VjdGlvbiBhZGRpbmcgYSAnbWluSXRlbXM6IDEnLiBUaGVuIGp1c3QKPiA+IGRlZmluZSAn bWluSXRlbXM6IDInIGhlcmUgYW5kICdtYXhJdGVtczogMScgaW4gdGhlICd0aGVuJyBjbGF1c2Uu Cj4gPiAKPiA+ID4gKwo+ID4gPiArcmVxdWlyZWQ6Cj4gPiA+ICsgIC0gY29tcGF0aWJsZQo+ID4g PiArICAtIHJlZwo+ID4gPiArICAtIGxhYmVsCj4gPiAKPiA+IEFkZDoKPiA+IAo+ID4gYWRkaXRp b25hbFByb3BlcnRpZXM6IGZhbHNlCj4gPiAKPiA+ID4gKwo+ID4gPiArZXhhbXBsZXM6Cj4gPiA+ ICsgIC0gfAo+ID4gPiArICAgIGJhY2tsaWdodEBkODAwIHsKPiA+ID4gKyAgICAgICAgY29tcGF0 aWJsZSA9ICJxY29tLHBtODk0MS13bGVkIjsKPiA+ID4gKyAgICAgICAgcmVnID0gPDB4ZDgwMCAw eDEwMD47Cj4gPiA+ICsgICAgICAgIGxhYmVsID0gImJhY2tsaWdodCI7Cj4gPiA+ICsKPiA+ID4g KyAgICAgICAgcWNvbSxjcy1vdXQ7Cj4gPiA+ICsgICAgICAgIHFjb20sY3VycmVudC1saW1pdCA9 IDwyMD47Cj4gPiA+ICsgICAgICAgIHFjb20sY3VycmVudC1ib29zdC1saW1pdCA9IDw4MDU+Owo+ ID4gPiArICAgICAgICBxY29tLHN3aXRjaGluZy1mcmVxID0gPDE2MDA+Owo+ID4gPiArICAgICAg ICBxY29tLG92cCA9IDwyOT47Cj4gPiA+ICsgICAgICAgIHFjb20sbnVtLXN0cmluZ3MgPSA8Mj47 Cj4gPiA+ICsgICAgICAgIHFjb20sZW5hYmxlZC1zdHJpbmdzID0gPDAgMT47Cj4gPiA+ICsgICAg IH07Cj4gVGhhbmtzIGZvciByZXZpZXdpbmcuIEkgd2lsbCBzdWJtaXQgdGhlIG5leHQgcmV2aXNp b24gd2l0aCBhbGwgdGhlIGZpeGVzLgoKUGxlYXNlIHRyaW0geW91ciByZXBsaWVzLgoKQWxzbywg aWYgeW91IGFncmVlIHdpdGggYWxsIG9mIHRoZSByZXZpZXcgY29tbWVudHMsIHRoZXJlIHJlYWxs eSBpcyBubwpuZWVkIHRvIHJlcGx5IGFuZC9vciB0aGFuayB0aGUgcmV2aWV3ZXIuICBTaW1wbHkg c3VibWl0IGEgc3Vic2VxdWVudApzZXQgd2l0aCBhIGJ1bXBlZCB2ZXJzaW9uIGluZGljYXRvci4K Ci0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNlcnZpY2VzIFRlY2huaWNhbCBMZWFk CkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cg TGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=