From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Tommi Rantala <tommi.t.rantala@nokia.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] perf cgroup: Avoid needless closing of unopened fd
Date: Mon, 20 Apr 2020 09:05:40 -0300 [thread overview]
Message-ID: <20200420120540.GB14597@kernel.org> (raw)
In-Reply-To: <20200420084847.GC718574@krava>
Em Mon, Apr 20, 2020 at 10:48:47AM +0200, Jiri Olsa escreveu:
> On Fri, Apr 17, 2020 at 04:23:26PM +0300, Tommi Rantala wrote:
> > Do not bother with close() if fd is not valid, just to silence valgrind:
> >
> > $ valgrind ./perf script
> > ==59169== Memcheck, a memory error detector
> > ==59169== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
> > ==59169== Using Valgrind-3.14.0 and LibVEX; rerun with -h for copyright info
> > ==59169== Command: ./perf script
> > ==59169==
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> > ==59169== Warning: invalid file descriptor -1 in syscall close()
> >
> > Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com>
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
Thanks, applied,
- Arnaldo
next prev parent reply other threads:[~2020-04-20 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 13:23 [PATCH 1/4] perf cgroup: Avoid needless closing of unopened fd Tommi Rantala
2020-04-17 13:23 ` [PATCH 2/4] perf tools: Move zstd_fini() to session deletion Tommi Rantala
2020-04-20 8:54 ` Jiri Olsa
2020-04-23 5:52 ` Rantala, Tommi T. (Nokia - FI/Espoo)
2020-04-17 13:23 ` [PATCH 3/4] perf tools: Fix segfaults due to missing zstd decompressor initialization Tommi Rantala
2020-04-20 9:05 ` Jiri Olsa
2020-04-17 13:23 ` [PATCH 4/4] perf bench: Fix div-by-zero if runtime is zero Tommi Rantala
2020-04-20 9:05 ` Jiri Olsa
2020-04-20 12:05 ` Arnaldo Carvalho de Melo
2020-05-08 13:05 ` [tip: perf/core] " tip-bot2 for Tommi Rantala
2020-04-20 8:48 ` [PATCH 1/4] perf cgroup: Avoid needless closing of unopened fd Jiri Olsa
2020-04-20 12:05 ` Arnaldo Carvalho de Melo [this message]
2020-05-08 13:05 ` [tip: perf/core] " tip-bot2 for Tommi Rantala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420120540.GB14597@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tommi.t.rantala@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.