diff for duplicates of <20200420124434.47330-3-aneesh.kumar@linux.ibm.com> diff --git a/a/1.txt b/N1/1.txt index fb5c5d7..fd2f89e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -54,8 +54,8 @@ static void pkey_handle_fault(int signum, siginfo_t *sinfo, void *ctx) printf("pkey: exp = %d, got = %d\n", faulting_pkey, sinfo->si_pkey); fflush(stdout); - assert(sinfo->si_code = SEGV_PKUERR); - assert(sinfo->si_pkey = faulting_pkey); + assert(sinfo->si_code == SEGV_PKUERR); + assert(sinfo->si_pkey == faulting_pkey); /* clear pkey permissions to let the faulting instruction continue */ pkeyreg_set(faulting_pkey, 0x0); @@ -200,7 +200,7 @@ The above test can result the below failure without this patch. pkey: exp = 3, got = 3 pkey: exp = 3, got = 4 -a.out: pkey-siginfo-race.c:100: pkey_handle_fault: Assertion `sinfo->si_pkey = faulting_pkey' failed. +a.out: pkey-siginfo-race.c:100: pkey_handle_fault: Assertion `sinfo->si_pkey == faulting_pkey' failed. Aborted Check for vma access before considering this a key fault. If vma pkey allow diff --git a/a/content_digest b/N1/content_digest index 94c5dcf..b14b1a8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,19 +1,18 @@ "ref\020200420124434.47330-1-aneesh.kumar@linux.ibm.com\0" "From\0Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>\0" "Subject\0[PATCH v3 02/22] powerpc/pkeys: Check vma before returning key fault error to the user\0" - "Date\0Mon, 20 Apr 2020 12:56:14 +0000\0" + "Date\0Mon, 20 Apr 2020 18:14:14 +0530\0" "To\0linuxppc-dev@lists.ozlabs.org" mpe@ellerman.id.au linux-mm@kvack.org linux-kernel@vger.kernel.org " kvm-ppc@vger.kernel.org\0" - "Cc\0npiggin@gmail.com" - paulus@ozlabs.org - leonardo@linux.ibm.com - kirill@shutemov.name + "Cc\0Ram Pai <linuxram@linux.ibm.com>" Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> - Ram Pai <linuxram@linux.ibm.com> - " Sandipan Das <sandipan@linux.ibm.com>\0" + npiggin@gmail.com + Sandipan Das <sandipan@linux.ibm.com> + kirill@shutemov.name + " leonardo@linux.ibm.com\0" "\00:1\0" "b\0" "If multiple threads in userspace keep changing the protection keys\n" @@ -72,8 +71,8 @@ "\tprintf(\"pkey: exp = %d, got = %d\\n\", faulting_pkey, sinfo->si_pkey);\n" "\tfflush(stdout);\n" "\n" - "\tassert(sinfo->si_code = SEGV_PKUERR);\n" - "\tassert(sinfo->si_pkey = faulting_pkey);\n" + "\tassert(sinfo->si_code == SEGV_PKUERR);\n" + "\tassert(sinfo->si_pkey == faulting_pkey);\n" "\n" "\t/* clear pkey permissions to let the faulting instruction continue */\n" "\tpkeyreg_set(faulting_pkey, 0x0);\n" @@ -218,7 +217,7 @@ "\n" "pkey: exp = 3, got = 3\n" "pkey: exp = 3, got = 4\n" - "a.out: pkey-siginfo-race.c:100: pkey_handle_fault: Assertion `sinfo->si_pkey = faulting_pkey' failed.\n" + "a.out: pkey-siginfo-race.c:100: pkey_handle_fault: Assertion `sinfo->si_pkey == faulting_pkey' failed.\n" "Aborted\n" "\n" "Check for vma access before considering this a key fault. If vma pkey allow\n" @@ -256,4 +255,4 @@ "-- \n" 2.25.3 -a948f088af7b61819dda9833e0395cdad7e4cdfccf3b2a8b3d61a4da6361c200 +e0e5d964bcb452ba65fc0e6082fae559f0a428bc7d4c0348b45ec281019d26ae
diff --git a/a/1.txt b/N2/1.txt index fb5c5d7..fd2f89e 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -54,8 +54,8 @@ static void pkey_handle_fault(int signum, siginfo_t *sinfo, void *ctx) printf("pkey: exp = %d, got = %d\n", faulting_pkey, sinfo->si_pkey); fflush(stdout); - assert(sinfo->si_code = SEGV_PKUERR); - assert(sinfo->si_pkey = faulting_pkey); + assert(sinfo->si_code == SEGV_PKUERR); + assert(sinfo->si_pkey == faulting_pkey); /* clear pkey permissions to let the faulting instruction continue */ pkeyreg_set(faulting_pkey, 0x0); @@ -200,7 +200,7 @@ The above test can result the below failure without this patch. pkey: exp = 3, got = 3 pkey: exp = 3, got = 4 -a.out: pkey-siginfo-race.c:100: pkey_handle_fault: Assertion `sinfo->si_pkey = faulting_pkey' failed. +a.out: pkey-siginfo-race.c:100: pkey_handle_fault: Assertion `sinfo->si_pkey == faulting_pkey' failed. Aborted Check for vma access before considering this a key fault. If vma pkey allow diff --git a/a/content_digest b/N2/content_digest index 94c5dcf..02d21d2 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,7 +1,7 @@ "ref\020200420124434.47330-1-aneesh.kumar@linux.ibm.com\0" "From\0Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>\0" "Subject\0[PATCH v3 02/22] powerpc/pkeys: Check vma before returning key fault error to the user\0" - "Date\0Mon, 20 Apr 2020 12:56:14 +0000\0" + "Date\0Mon, 20 Apr 2020 18:14:14 +0530\0" "To\0linuxppc-dev@lists.ozlabs.org" mpe@ellerman.id.au linux-mm@kvack.org @@ -72,8 +72,8 @@ "\tprintf(\"pkey: exp = %d, got = %d\\n\", faulting_pkey, sinfo->si_pkey);\n" "\tfflush(stdout);\n" "\n" - "\tassert(sinfo->si_code = SEGV_PKUERR);\n" - "\tassert(sinfo->si_pkey = faulting_pkey);\n" + "\tassert(sinfo->si_code == SEGV_PKUERR);\n" + "\tassert(sinfo->si_pkey == faulting_pkey);\n" "\n" "\t/* clear pkey permissions to let the faulting instruction continue */\n" "\tpkeyreg_set(faulting_pkey, 0x0);\n" @@ -218,7 +218,7 @@ "\n" "pkey: exp = 3, got = 3\n" "pkey: exp = 3, got = 4\n" - "a.out: pkey-siginfo-race.c:100: pkey_handle_fault: Assertion `sinfo->si_pkey = faulting_pkey' failed.\n" + "a.out: pkey-siginfo-race.c:100: pkey_handle_fault: Assertion `sinfo->si_pkey == faulting_pkey' failed.\n" "Aborted\n" "\n" "Check for vma access before considering this a key fault. If vma pkey allow\n" @@ -256,4 +256,4 @@ "-- \n" 2.25.3 -a948f088af7b61819dda9833e0395cdad7e4cdfccf3b2a8b3d61a4da6361c200 +7eb34019ceb604cb799d3ddf34d29710ccdf0693a8ed77149820e607c3627b1a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.