All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Vagin <avagin@gmail.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	linux-kernel@vger.kernel.org,
	Dmitry Safonov <0x7f454c46@gmail.com>,
	Dmitry Safonov <dima@arista.com>
Subject: Re: [PATCH] vdso/datapage: use correct clock mode name in comment
Date: Mon, 20 Apr 2020 09:03:34 -0700	[thread overview]
Message-ID: <20200420160334.GA925174@gmail.com> (raw)
In-Reply-To: <20200420100615.1549804-1-christian.brauner@ubuntu.com>

On Mon, Apr 20, 2020 at 12:06:15PM +0200, Christian Brauner wrote:
> While the explanation for time namespace <-> vdso interactions is very
> helpful it uses the wrong name in the comment when describing the clock
> mode making grepping a bit annoying.
> 
> This seems like an accidental oversight when moving from VCLOCK_TIMENS
> to VDSO_CLOCKMODE_TIMENS. It seems that
> 660fd04f9317 ("lib/vdso: Prepare for time namespace support") misspelled
> VCLOCK_TIMENS as VLOCK_TIMENS which explains why it got missed when
> VCLOCK_TIMENS became VDSO_CLOCKMODE_TIMENS in
> 2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes").
> 
> Update the commit to use VDSO_CLOCKMODE_TIMENS.
> 
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Dmitry Safonov <dima@arista.com>
> Cc: Andrei Vagin <avagin@gmail.com>
> Fixes: 660fd04f9317 ("lib/vdso: Prepare for time namespace support")
> Fixes: 2d6b01bd88cc ("lib/vdso: Move VCLOCK_TIMENS to vdso_clock_modes")
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Acked-by: Andrei Vagin <avagin@gmail.com>

Thanks,
Andrei

  parent reply	other threads:[~2020-04-20 16:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 10:06 [PATCH] vdso/datapage: use correct clock mode name in comment Christian Brauner
2020-04-20 11:17 ` Vincenzo Frascino
2020-04-20 16:03 ` Andrei Vagin [this message]
2020-04-20 17:27 ` [tip: timers/urgent] vdso/datapage: Use " tip-bot2 for Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200420160334.GA925174@gmail.com \
    --to=avagin@gmail.com \
    --cc=0x7f454c46@gmail.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=dima@arista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.