From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, Henrik Rydberg <rydberg@bitmath.org>
Subject: Re: [PATCH 1/2 v4] dt-bindings: touchscreen: Add CY8CTMA140 bindings
Date: Mon, 20 Apr 2020 12:58:35 -0500 [thread overview]
Message-ID: <20200420175835.GA3511@bogus> (raw)
In-Reply-To: <20200417204312.13453-1-linus.walleij@linaro.org>
On Fri, 17 Apr 2020 22:43:11 +0200, Linus Walleij wrote:
> This adds device tree bindings for the Cypress CY8CTMA140
> touchscreen.
>
> Cc: devicetree@vger.kernel.org
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v4:
> - Drop the description of 'reg', it's surplus.
> - Set the I2C frequency to the span 100k to 400k instead
> of hardcoding 400k.
> - Collect Rob's review tag.
> ---
> .../input/touchscreen/cypress,cy8ctma140.yaml | 72 +++++++++++++++++++
> 1 file changed, 72 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,cy8ctma140.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/input/touchscreen/cypress,cy8ctma140.example.dts:18.22-32.11: Warning (unit_address_vs_reg): /example-0/i2c@00000000: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/input/touchscreen/cypress,cy8ctma140.example.dts:18.22-32.11: Warning (unit_address_format): /example-0/i2c@00000000: unit name should not have leading 0s
See https://patchwork.ozlabs.org/patch/1272475
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.
prev parent reply other threads:[~2020-04-20 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 20:43 [PATCH 1/2 v4] dt-bindings: touchscreen: Add CY8CTMA140 bindings Linus Walleij
2020-04-17 20:43 ` [PATCH 2/2 v4] Input: cy8ctma140 - add driver Linus Walleij
2020-04-20 17:58 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420175835.GA3511@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.