From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFECC38A30 for ; Mon, 20 Apr 2020 18:27:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BA8F206E9 for ; Mon, 20 Apr 2020 18:27:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BA8F206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CB2DE6E1E2; Mon, 20 Apr 2020 18:27:25 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id F298A6E1E2 for ; Mon, 20 Apr 2020 18:27:24 +0000 (UTC) IronPort-SDR: LsIZlqC/av84B6u9L15sHFlSF6ymxXEZEPaC6L8XOxOgn43BufMP5299Hsm/0vJvQrp82WT9Lg qPtUfasgchVQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 11:27:24 -0700 IronPort-SDR: n0m56/ijoF9pa6I1ludpPXSyGSQ7/f7TIktLp8ugiJEf/oEgfKOjFaETdUyqLybtUQ9Ldf3eTs VzLOrk4vdFLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,407,1580803200"; d="scan'208";a="273264233" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 20 Apr 2020 11:27:22 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 20 Apr 2020 21:27:20 +0300 Date: Mon, 20 Apr 2020 21:27:20 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: <20200420182720.GZ6112@intel.com> References: <20200417134720.16654-1-ville.syrjala@linux.intel.com> <20200417134720.16654-2-ville.syrjala@linux.intel.com> <87mu761aj6.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87mu761aj6.fsf@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 2/4] drm/i915: Move the TRANS_DDI_FUNC_CTL enable to a later point X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Apr 20, 2020 at 05:45:01PM +0300, Jani Nikula wrote: > On Fri, 17 Apr 2020, Ville Syrjala wrote: > > From: Ville Syrj=E4l=E4 > > > > No reason that I can see why we should enable TRANS_DDI_FUNC_CTL > > before we set up the watermarks of confogiure the mbus stuff. > > In fact reordering these seems to match the bspec sequence better, > > and cricually will allow us to push the TRANS_DDI_FUNC_CTL enable > ^^^^^^^^^ > = > The entire series is nice, but I especially like this "crucially" > typo. It looks prezactly like a mix of crucially and critically. Wasn't the only typo. One day I need to invest in a spell checker. > = > FWIW the series is Acked-by me, as Chris beat me to review. I also > didn't spot anything obviously wrong. Thanks for the reviews/acks. Series pushed to dinq. > = > BR, > Jani. > = > = > > into the encoder enable hook as a followup. > > > > Signed-off-by: Ville Syrj=E4l=E4 > > --- > > drivers/gpu/drm/i915/display/intel_display.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu= /drm/i915/display/intel_display.c > > index af5b4055b38a..7a1e7b5ae84e 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -7071,15 +7071,15 @@ static void hsw_crtc_enable(struct intel_atomic= _state *state, > > if (INTEL_GEN(dev_priv) >=3D 11) > > icl_set_pipe_chicken(crtc); > > = > > - if (!transcoder_is_dsi(cpu_transcoder)) > > - intel_ddi_enable_transcoder_func(new_crtc_state); > > - > > if (dev_priv->display.initial_watermarks) > > dev_priv->display.initial_watermarks(state, crtc); > > = > > if (INTEL_GEN(dev_priv) >=3D 11) > > icl_pipe_mbus_enable(crtc); > > = > > + if (!transcoder_is_dsi(cpu_transcoder)) > > + intel_ddi_enable_transcoder_func(new_crtc_state); > > + > > intel_encoders_enable(state, crtc); > > = > > if (psl_clkgate_wa) { > = > -- = > Jani Nikula, Intel Open Source Graphics Center -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx