From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFC1FC38A30 for ; Mon, 20 Apr 2020 18:34:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3BEC2074F for ; Mon, 20 Apr 2020 18:34:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3BEC2074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 689136E840; Mon, 20 Apr 2020 18:34:48 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E1DD6E840 for ; Mon, 20 Apr 2020 18:34:47 +0000 (UTC) IronPort-SDR: DzjBNGG1aZ7tXt24sQmaeawYWBQvENbLk48k1r4bWKgK3C/hc4S0W3h93ltMOFG111ZZT6PxdB mvM/NzWdB8LA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 11:34:46 -0700 IronPort-SDR: waTZLtbQz9hzosy1vnHaauFTpf/TSQ+S0vZfel+Aw7PsPgTmejSVLc5nVs6tkJ6K9yYq0lYfEg MtFMcN+LAMvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,407,1580803200"; d="scan'208";a="290188308" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga002.fm.intel.com with SMTP; 20 Apr 2020 11:34:44 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 20 Apr 2020 21:34:41 +0300 Date: Mon, 20 Apr 2020 21:34:41 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Chris Wilson Message-ID: <20200420183441.GB6112@intel.com> References: <20200417134720.16654-1-ville.syrjala@linux.intel.com> <20200417134720.16654-3-ville.syrjala@linux.intel.com> <158715309508.2062.2790073223349657193@build.alporthouse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <158715309508.2062.2790073223349657193@build.alporthouse.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915: Push TRANS_DDI_FUNC_CTL into the encoder->enable() hook X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Apr 17, 2020 at 08:51:35PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2020-04-17 14:47:19) > > From: Ville Syrj=E4l=E4 > > = > > Push the TRANS_DDI_FUNC_CTL into the encoder enable hook. The disable > > is already there, and as a followup will enable us to pass the encoder > > all the way down. > > = > > Signed-off-by: Ville Syrj=E4l=E4 > = > In intel_ddi_transcoder_func_reg_val_get() I found a list of ddi > crtc types (HDMI, ANALOG, DP_MST, DP_SST). Now hdmi/dp =3D=3D ddi, and so= we > are left with dp_mst and crt callbacks. > = > Reviewed-by: Chris Wilson > = > Is it possible to have more BUG_ON(!transcoder_is_ddi()) scatter around > the entry points? I guess we could assert something about either the output_types or the encoder type, but not sure that would get us much. Bunch of that is anyway the same for pre-DDI stuff. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx