All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5/Config.in: fix typo
Date: Mon, 20 Apr 2020 20:37:31 +0200	[thread overview]
Message-ID: <20200420203731.7ba7796d@gmx.net> (raw)
In-Reply-To: <20200420152910.GI5035@scaer>

Hello Yann, Bartosz,

On Mon, 20 Apr 2020 17:29:10 +0200, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Bartosz, All,
>
> On 2020-04-20 17:10 +0200, Bartosz Bilas spake thusly:
> > There is no BR2_TOOLCHAIN_GCC_AT_LEAST_5_0 option
> > but BR2_TOOLCHAIN_GCC_AT_LEAST_5.

Argh....only checked for the disabling case and did not check the positive one....

> >
> > Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
>
> I also fixed pinentry and wireshark, which had the incorrect version
> introduced with the same commit as qt5. Adapted the commit log and
> pushed to master, thanks.

Thanks to both of you for fixing my mistake...

Regards,
Peter

>
> Regards,
> Yann E. MORIN.
>
> > ---
> >  package/qt5/Config.in | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/qt5/Config.in b/package/qt5/Config.in
> > index cd9c93735d..c716919476 100644
> > --- a/package/qt5/Config.in
> > +++ b/package/qt5/Config.in
> > @@ -16,14 +16,14 @@ comment "Qt5 needs a toolchain w/ gcc >= 5.0, wchar, NPTL, C++, dynamic library"
> >  	depends on !BR2_arc
> >  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> >  		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS || \
> > -		!BR2_TOOLCHAIN_GCC_AT_LEAST_5_0
> > +		!BR2_TOOLCHAIN_GCC_AT_LEAST_5
> >
> >  menuconfig BR2_PACKAGE_QT5
> >  	bool "Qt5"
> >  	depends on BR2_INSTALL_LIBSTDCPP
> >  	depends on BR2_USE_WCHAR
> >  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> > -	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5_0 # C++11, GCC_BUG_57694
> > +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 # C++11, GCC_BUG_57694
> >  	depends on !BR2_ARM_CPU_ARMV4 # needs ARMv5+
> >  	# no built-in double-conversion support
> >  	depends on !BR2_arc
> > --
> > 2.26.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>

      parent reply	other threads:[~2020-04-20 18:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 15:10 [Buildroot] [PATCH] package/qt5/Config.in: fix typo Bartosz Bilas
2020-04-20 15:29 ` Yann E. MORIN
2020-04-20 15:36   ` Bartosz Bilas
2020-04-20 18:37   ` Peter Seiderer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200420203731.7ba7796d@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.