From: Greg KH <gregkh@linuxfoundation.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, Dave Ertman <david.m.ertman@intel.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com, jgg@ziepe.ca,
parav@mellanox.com, galpress@amazon.com,
selvin.xavier@broadcom.com, sriharsha.basavapatna@broadcom.com,
benve@cisco.com, bharat@chelsio.com, xavier.huwei@huawei.com,
yishaih@mellanox.com, leonro@mellanox.com, mkalderon@marvell.com,
aditr@vmware.com, ranjani.sridharan@linux.intel.com,
pierre-louis.bossart@linux.intel.com,
Kiran Patil <kiran.patil@intel.com>,
Andrew Bowers <andrewx.bowers@intel.com>
Subject: Re: [net-next v2 1/9] Implementation of Virtual Bus
Date: Tue, 21 Apr 2020 10:47:37 +0200 [thread overview]
Message-ID: <20200421084737.GE716720@kroah.com> (raw)
In-Reply-To: <20200421080235.6515-2-jeffrey.t.kirsher@intel.com>
On Tue, Apr 21, 2020 at 01:02:27AM -0700, Jeff Kirsher wrote:
> +struct virtbus_driver {
> + int (*probe)(struct virtbus_device *);
> + int (*remove)(struct virtbus_device *);
> + void (*shutdown)(struct virtbus_device *);
> + int (*suspend)(struct virtbus_device *, pm_message_t);
> + int (*resume)(struct virtbus_device *);
> + struct device_driver driver;
> + const struct virtbus_dev_id *id_table;
> +};
You create this type of driver, but then never use it in your
implementations that happen to create virtbus devices. So does that
imply that you do not need virbus_drivers at all? Why add all of this
code that never gets used?
Or perhaps you should be creating a virbus driver? I can't tell, but as
it is, this series is not ready to be merged.
greg k-h
next prev parent reply other threads:[~2020-04-21 8:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 8:02 [net-next v2 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2020-04-20 Jeff Kirsher
2020-04-21 8:02 ` [net-next v2 1/9] Implementation of Virtual Bus Jeff Kirsher
2020-04-21 8:37 ` Greg KH
2020-04-21 8:50 ` Kirsher, Jeffrey T
2020-04-21 9:30 ` Greg KH
2020-04-21 23:27 ` Ertman, David M
2020-04-21 8:47 ` Greg KH [this message]
2020-04-21 9:08 ` Leon Romanovsky
2020-04-21 23:27 ` Ertman, David M
2020-04-21 12:08 ` Jason Gunthorpe
2020-04-21 23:27 ` Ertman, David M
2020-04-21 15:58 ` Ranjani Sridharan
2020-04-21 8:02 ` [net-next v2 2/9] ice: Create and register virtual bus for RDMA Jeff Kirsher
2020-04-21 8:44 ` Greg KH
2020-04-21 8:02 ` [net-next v2 3/9] ice: Complete RDMA peer registration Jeff Kirsher
2020-04-21 8:02 ` [net-next v2 4/9] ice: Support resource allocation requests Jeff Kirsher
2020-04-21 8:02 ` [net-next v2 5/9] ice: Enable event notifications Jeff Kirsher
2020-04-21 8:02 ` [net-next v2 6/9] ice: Allow reset operations Jeff Kirsher
2020-04-21 8:02 ` [net-next v2 7/9] ice: Pass through communications to VF Jeff Kirsher
2020-04-21 8:02 ` [net-next v2 8/9] i40e: Move client header location Jeff Kirsher
2020-04-21 8:02 ` [net-next v2 9/9] i40e: Register a virtbus device to provide RDMA Jeff Kirsher
2020-04-21 8:15 ` [net-next v2 0/9][pull request] 100GbE Intel Wired LAN Driver Updates 2020-04-20 Kirsher, Jeffrey T
2020-04-21 8:30 ` gregkh
2020-04-21 8:37 ` Kirsher, Jeffrey T
2020-04-22 19:55 ` David Miller
2020-04-21 12:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421084737.GE716720@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aditr@vmware.com \
--cc=andrewx.bowers@intel.com \
--cc=benve@cisco.com \
--cc=bharat@chelsio.com \
--cc=davem@davemloft.net \
--cc=david.m.ertman@intel.com \
--cc=galpress@amazon.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jgg@ziepe.ca \
--cc=kiran.patil@intel.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=parav@mellanox.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sassmann@redhat.com \
--cc=selvin.xavier@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=xavier.huwei@huawei.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.