From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB595C54FC9 for ; Tue, 21 Apr 2020 12:10:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADB80206A5 for ; Tue, 21 Apr 2020 12:10:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PxVZHB6u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADB80206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rUm1vLRTYf5RLrolCCzEHxsk0XLmDypKd0vZWWCL8W4=; b=PxVZHB6ueVoq+6 5Te1izfQkX1oII/pkYIRp0Z7bIxbCCo0YodWNEYk/Mx/TKB12Nne0NEequl2zybuSvsuw8D0WZH62 haZqx1dLD1SI9yKhN7yiWoaYt3U3UV7sQ0mYrbwpA+TJuisYrgM166NiO4EaGjly8WsQGTdBW9nF9 pgz15ADAA2ihn7KlHCRsl76feKQkznJdIzONIlcZSNABygYfMVn15V1W1YlgPodlvmHjC6wvkh80+ K28/GxCyDmE8BJPa1WzktwQOVFsSAJ1SX6efd9MPMtl5wxC2bZQAM9H4/ucP/g+kipWTq53lOYkOS PxHthKRaiZbmAveFLd9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQrj0-0006jd-Jv; Tue, 21 Apr 2020 12:10:02 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQrix-0006dn-D9 for linux-nvme@lists.infradead.org; Tue, 21 Apr 2020 12:10:00 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6E6EE68C4E; Tue, 21 Apr 2020 14:09:57 +0200 (CEST) Date: Tue, 21 Apr 2020 14:09:57 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 04/17] nvme: introduce max_integrity_segments ctrl attribute Message-ID: <20200421120957.GE26432@lst.de> References: <20200327171545.98970-1-maxg@mellanox.com> <20200327171545.98970-6-maxg@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200327171545.98970-6-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200421_050959_592521_02B6FD99 X-CRM114-Status: UNSURE ( 7.37 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, jsmart2021@gmail.com, sagi@grimberg.me, martin.petersen@oracle.com, shlomin@mellanox.com, linux-rdma@vger.kernel.org, israelr@mellanox.com, vladimirk@mellanox.com, linux-nvme@lists.infradead.org, idanb@mellanox.com, jgg@mellanox.com, oren@mellanox.com, kbusch@kernel.org, hch@lst.de Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org T24gRnJpLCBNYXIgMjcsIDIwMjAgYXQgMDg6MTU6MzJQTSArMDMwMCwgTWF4IEd1cnRvdm95IHdy b3RlOgo+ICsJLyoKPiArCSAqIE5WTWUgUENJIGRyaXZlciBkb2Vzbid0IHN1cHBvcnQgRXh0ZW5k ZWQgTEJBIGZvcm1hdCBhbmQgc3VwcG9ydHMKPiArCSAqIG9ubHkgYSBzaW5nbGUgaW50ZWdyaXR5 IHNlZ21lbnQgZm9yIGEgc2VwYXJhdGUgY29udGlndW91cyBidWZmZXIKPiArCSAqIG9mIG1ldGFk YXRhLgo+ICsJICovCgpUaGF0IGlzbid0IHN0cmljdGx5IHRydWUsIFBDSWUgY2FuIGFsc28gc3Vw cG9ydCBTR0xzIGZvciBtZXRhZGF0YS4KCkknZCByYXRoZXIg0ZVheSBzb21ldGhpbmcgbGlrZToK CgkvKgoJICogV2UgZG8gbm90IHN1cHBvcnQgYW4gU0dMIGZvciBtZXRhZGF0YSAoeWV0KSwgc28g d2UgYXJlIGxpbWl0ZWQKCSAqIHRvIGEgc2luZ2xlIGludGVncml0eSBzZWdtZW50IGZvciB0aGUg c2VwYXJhdGUgbWV0YWRhdGEgcG9pbnRlci4KCSAqLwoKRXhjZXB0IGZvciB0aGF0IHRoaXMgbG9v a3MgZ29vZDoKClJldmlld2VkLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4KCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LW52bWUg bWFpbGluZyBsaXN0CmxpbnV4LW52bWVAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW52bWUK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC48C54FC9 for ; Tue, 21 Apr 2020 12:10:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EA50206A5 for ; Tue, 21 Apr 2020 12:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbgDUMKA (ORCPT ); Tue, 21 Apr 2020 08:10:00 -0400 Received: from verein.lst.de ([213.95.11.211]:46318 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbgDUMKA (ORCPT ); Tue, 21 Apr 2020 08:10:00 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6E6EE68C4E; Tue, 21 Apr 2020 14:09:57 +0200 (CEST) Date: Tue, 21 Apr 2020 14:09:57 +0200 From: Christoph Hellwig To: Max Gurtovoy Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, martin.petersen@oracle.com, jsmart2021@gmail.com, linux-rdma@vger.kernel.org, idanb@mellanox.com, axboe@kernel.dk, vladimirk@mellanox.com, oren@mellanox.com, shlomin@mellanox.com, israelr@mellanox.com, jgg@mellanox.com Subject: Re: [PATCH 04/17] nvme: introduce max_integrity_segments ctrl attribute Message-ID: <20200421120957.GE26432@lst.de> References: <20200327171545.98970-1-maxg@mellanox.com> <20200327171545.98970-6-maxg@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200327171545.98970-6-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Mar 27, 2020 at 08:15:32PM +0300, Max Gurtovoy wrote: > + /* > + * NVMe PCI driver doesn't support Extended LBA format and supports > + * only a single integrity segment for a separate contiguous buffer > + * of metadata. > + */ That isn't strictly true, PCIe can also support SGLs for metadata. I'd rather ѕay something like: /* * We do not support an SGL for metadata (yet), so we are limited * to a single integrity segment for the separate metadata pointer. */ Except for that this looks good: Reviewed-by: Christoph Hellwig