From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7058C54FD0 for ; Tue, 21 Apr 2020 12:13:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7333D206A5 for ; Tue, 21 Apr 2020 12:13:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fdTqymp1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7333D206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U3F0gIFeQ23CQzCBV+hIkmxQTYxaqdgVtB/BfQs58j8=; b=fdTqymp1FbjdPi 4PwfooYP5qJwZ9KfI76ynfsHt6sXnK01sPY/zIZxhuKcLJ4asoyU3I7svVvrm8Ku+mxSgKbfp8fVa MkwkPY4Ir9+8jtU+qBZ6zM8Rt7vq+4bs5iI6o4DGkL8/LWYtcAgJK9KRUsJNSu4wfXegNG/WCh64O 6gxlMAvsl7GDTgct8IMcUSdeTv0b31DLbneBhz17fSTxR/IiKHch5tUWIChX63nCpqM25c/mHux7U 5Duz3kaZKmFA53sG8cssErzcE1h/pkBYg9Hw06sJwP8D6fGvjN3Q0hdwYh5r6I7Dg8XZwqkdiMTiT Dz3sY90bYgUVKJFZ0Evw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQrmQ-0001lF-UN; Tue, 21 Apr 2020 12:13:34 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQrmN-0001kF-RG for linux-nvme@lists.infradead.org; Tue, 21 Apr 2020 12:13:33 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E958868C4E; Tue, 21 Apr 2020 14:13:29 +0200 (CEST) Date: Tue, 21 Apr 2020 14:13:29 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 07/17] nvme-rdma: Introduce nvme_rdma_sgl structure Message-ID: <20200421121329.GH26432@lst.de> References: <20200327171545.98970-1-maxg@mellanox.com> <20200327171545.98970-9-maxg@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200327171545.98970-9-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200421_051332_633815_311C9485 X-CRM114-Status: UNSURE ( 7.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, jsmart2021@gmail.com, sagi@grimberg.me, martin.petersen@oracle.com, shlomin@mellanox.com, linux-rdma@vger.kernel.org, israelr@mellanox.com, vladimirk@mellanox.com, linux-nvme@lists.infradead.org, idanb@mellanox.com, jgg@mellanox.com, oren@mellanox.com, kbusch@kernel.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Fri, Mar 27, 2020 at 08:15:35PM +0300, Max Gurtovoy wrote: > From: Israel Rukshin > > Remove first_sgl pointer from struct nvme_rdma_request and use pointer > arithmetic instead. The inline scatterlist, if exists, will be located > right after the nvme_rdma_request. This patch is needed as a preparation > for adding PI support. > > Signed-off-by: Israel Rukshin > Reviewed-by: Max Gurtovoy Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E3FC54FC9 for ; Tue, 21 Apr 2020 12:13:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD8AF206A5 for ; Tue, 21 Apr 2020 12:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728597AbgDUMNc (ORCPT ); Tue, 21 Apr 2020 08:13:32 -0400 Received: from verein.lst.de ([213.95.11.211]:46365 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726741AbgDUMNc (ORCPT ); Tue, 21 Apr 2020 08:13:32 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id E958868C4E; Tue, 21 Apr 2020 14:13:29 +0200 (CEST) Date: Tue, 21 Apr 2020 14:13:29 +0200 From: Christoph Hellwig To: Max Gurtovoy Cc: linux-nvme@lists.infradead.org, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, martin.petersen@oracle.com, jsmart2021@gmail.com, linux-rdma@vger.kernel.org, idanb@mellanox.com, axboe@kernel.dk, vladimirk@mellanox.com, oren@mellanox.com, shlomin@mellanox.com, israelr@mellanox.com, jgg@mellanox.com Subject: Re: [PATCH 07/17] nvme-rdma: Introduce nvme_rdma_sgl structure Message-ID: <20200421121329.GH26432@lst.de> References: <20200327171545.98970-1-maxg@mellanox.com> <20200327171545.98970-9-maxg@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200327171545.98970-9-maxg@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Mar 27, 2020 at 08:15:35PM +0300, Max Gurtovoy wrote: > From: Israel Rukshin > > Remove first_sgl pointer from struct nvme_rdma_request and use pointer > arithmetic instead. The inline scatterlist, if exists, will be located > right after the nvme_rdma_request. This patch is needed as a preparation > for adding PI support. > > Signed-off-by: Israel Rukshin > Reviewed-by: Max Gurtovoy Looks good, Reviewed-by: Christoph Hellwig