From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21EEBC54FD0 for ; Tue, 21 Apr 2020 12:17:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E74EE2064C for ; Tue, 21 Apr 2020 12:17:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kw0Wa0uh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E74EE2064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nvNG1nwygHVZPiv/2e/zGCTJWRt40T1b9Q4VdpJ7s8s=; b=kw0Wa0uh5pQwGl R5gY6FaKT2LlTVYBE5oLe05BFHB2d7fmHtl2L6ChZAi1FbEm2EO1kAuHjfLHaMiWo8cs2yj57ZWxb uoVG8jlDzYJR5iEDgmxGiKxGYf7rV0P0DeKyE4C9BWesH/cOWd0NIGM0YOGAaMD3Fg7SuDEXjhDf6 OFbYYm1lMpVF1ysJ11qe7ASKW7MNg/MS2MVVdJWJKC4BFbyBqG29JtqDqNFCbYNq/GOEdHUge4pHf lvYA4M05g7bNk5EYDz5bVP9YMp4E5IGHGPaamQwNkLfDzGz4EgPpdmDCcHK4ZAIALJrTXTlOFa1u3 QnpI3pxuNMLAVATNx/fw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQrqP-0005i4-Kz; Tue, 21 Apr 2020 12:17:41 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQrqK-0005eT-MD for linux-mtd@lists.infradead.org; Tue, 21 Apr 2020 12:17:39 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 04A992A1640; Tue, 21 Apr 2020 13:17:32 +0100 (BST) Date: Tue, 21 Apr 2020 14:17:25 +0200 From: Boris Brezillon To: Vignesh Raghavendra Subject: Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode Message-ID: <20200421141725.24ce5986@collabora.com> In-Reply-To: <56365995-fe30-534f-9dbc-7307d9b9f846@ti.com> References: <1587451187-6889-1-git-send-email-masonccyang@mxic.com.tw> <20200421092328.129308f6@collabora.com> <56365995-fe30-534f-9dbc-7307d9b9f846@ti.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200421_051736_872514_E14C2DA8 X-CRM114-Status: GOOD ( 20.52 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tudor.ambarus@microchip.com, juliensu@mxic.com.tw, richard@nod.at, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org, linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com, Mason Yang , Pratyush Yadav Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 21 Apr 2020 15:05:08 +0530 Vignesh Raghavendra wrote: > On 21/04/20 12:53 pm, Boris Brezillon wrote: > > +Pratyush who's working on a similar patchet [1]. > > > > Hello Mason, > > > > On Tue, 21 Apr 2020 14:39:42 +0800 > > Mason Yang wrote: > > > >> Hello, > >> > >> This is repost of patchset from Boris Brezillon's > >> [RFC,00/18] mtd: spi-nor: Proposal for 8-8-8 mode support [1]. > > > > I only quickly went through the patches you sent and saying it's a > > repost of the RFC is a bit of a lie. You completely ignored the state > > tracking I was trying to do to avoid leaving the flash in 8D mode when > > suspending/resetting the board, and I think that part is crucial. If I > > remember correctly, we already had this discussion so I must say I'm a > > bit disappointed. > > > > Can you sync with Pratyush? I think his series [1] is better in that it > > tries to restore the flash in single-SPI mode before suspend (it's > > missing the shutdown case, but that can be easily added I think). Of > > course that'd be even better to have proper state tracking at the SPI > > NOR level. > > > > [1] does soft reset on shutdown which should put it to reset default > state of 1S-1S-1S mode (if thats the POR default) Oh ok, looks like I didn't read the patch series carefully enough. > > But, there is still one open question now that we are considering > supporting stateful modes: > > What to do with flashes that power up in 8D mode either due to factory > defaults or if 8D mode NV bit is set? Do we say SPI NOR framework won't > support such flashes? > Auto discovery of such flashes is quite difficult as different flashes > use different protocols for RDID cmd in 8D mode (address phase may or > may not be present, dummy cycles vary etc) is almost impossible w/o any > hint passed to the driver? I don't know yet. Looks like we'll have to pass the part-id and default mode for those flashes (part-name being a part-specific compatible, and boot-up mode being an extra property). But maybe we can ignore that for now and focus on flashes booting in single SPI mode first :P. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBC57C54FC9 for ; Tue, 21 Apr 2020 12:17:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D00592064C for ; Tue, 21 Apr 2020 12:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728773AbgDUMRf (ORCPT ); Tue, 21 Apr 2020 08:17:35 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:33096 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbgDUMRf (ORCPT ); Tue, 21 Apr 2020 08:17:35 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 04A992A1640; Tue, 21 Apr 2020 13:17:32 +0100 (BST) Date: Tue, 21 Apr 2020 14:17:25 +0200 From: Boris Brezillon To: Vignesh Raghavendra Cc: Mason Yang , , , , , , , , , Pratyush Yadav Subject: Re: [PATCH v2 0/5] mtd: spi-nor: Add support for Octal 8D-8D-8D mode Message-ID: <20200421141725.24ce5986@collabora.com> In-Reply-To: <56365995-fe30-534f-9dbc-7307d9b9f846@ti.com> References: <1587451187-6889-1-git-send-email-masonccyang@mxic.com.tw> <20200421092328.129308f6@collabora.com> <56365995-fe30-534f-9dbc-7307d9b9f846@ti.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org On Tue, 21 Apr 2020 15:05:08 +0530 Vignesh Raghavendra wrote: > On 21/04/20 12:53 pm, Boris Brezillon wrote: > > +Pratyush who's working on a similar patchet [1]. > > > > Hello Mason, > > > > On Tue, 21 Apr 2020 14:39:42 +0800 > > Mason Yang wrote: > > > >> Hello, > >> > >> This is repost of patchset from Boris Brezillon's > >> [RFC,00/18] mtd: spi-nor: Proposal for 8-8-8 mode support [1]. > > > > I only quickly went through the patches you sent and saying it's a > > repost of the RFC is a bit of a lie. You completely ignored the state > > tracking I was trying to do to avoid leaving the flash in 8D mode when > > suspending/resetting the board, and I think that part is crucial. If I > > remember correctly, we already had this discussion so I must say I'm a > > bit disappointed. > > > > Can you sync with Pratyush? I think his series [1] is better in that it > > tries to restore the flash in single-SPI mode before suspend (it's > > missing the shutdown case, but that can be easily added I think). Of > > course that'd be even better to have proper state tracking at the SPI > > NOR level. > > > > [1] does soft reset on shutdown which should put it to reset default > state of 1S-1S-1S mode (if thats the POR default) Oh ok, looks like I didn't read the patch series carefully enough. > > But, there is still one open question now that we are considering > supporting stateful modes: > > What to do with flashes that power up in 8D mode either due to factory > defaults or if 8D mode NV bit is set? Do we say SPI NOR framework won't > support such flashes? > Auto discovery of such flashes is quite difficult as different flashes > use different protocols for RDID cmd in 8D mode (address phase may or > may not be present, dummy cycles vary etc) is almost impossible w/o any > hint passed to the driver? I don't know yet. Looks like we'll have to pass the part-id and default mode for those flashes (part-name being a part-specific compatible, and boot-up mode being an extra property). But maybe we can ignore that for now and focus on flashes booting in single SPI mode first :P.