From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Ani Sinha <ani.sinha@nutanix.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses
Date: Tue, 21 Apr 2020 16:02:01 +0100 [thread overview]
Message-ID: <20200421150201.GI479771@redhat.com> (raw)
In-Reply-To: <07BC06B8-34F6-4C46-ACCE-DD7A4CBA9BC7@nutanix.com>
On Tue, Apr 21, 2020 at 02:45:04PM +0000, Ani Sinha wrote:
>
>
> > On Apr 20, 2020, at 8:32 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > But I for one would like to focus on keeping PIIX stable
> > and focus development on q35. Not bloating PIIX with lots of new
> > features is IMHO a good way to do that.
>
> Does this mean this patch is a no-go then? :(
I'd support this patch, as I don't think it can really be described as
bloat or destabalizing. It is just adding a simple property to
conditionalize existing functionality. Telling people to switch to Q35
is unreasonable as it is not a simple 1-1 conversion from existing use
of PIIX. Q35 has much higher complexity in its configuration, has higher
memory overhead per VM too, and lacks certain features of PIIX too.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-04-21 15:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 15:13 [PATCH] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses Ani Sinha
2020-04-17 15:27 ` Michael S. Tsirkin
2020-04-17 15:36 ` Ani Sinha
2020-04-17 16:09 ` Michael S. Tsirkin
2020-04-17 16:35 ` Ani Sinha
2020-04-17 21:56 ` Laine Stump
2020-04-18 3:25 ` Ani Sinha
2020-04-18 12:48 ` Marcel Apfelbaum
2020-04-19 4:00 ` Ani Sinha
2020-04-20 15:04 ` Ani Sinha
2020-04-20 15:38 ` Ani Sinha
2020-04-20 18:35 ` Julia Suvorova
2020-04-20 9:24 ` Daniel P. Berrangé
2020-04-20 10:33 ` Ani Sinha
2020-04-20 11:40 ` Philippe Mathieu-Daudé
2020-04-20 15:02 ` Michael S. Tsirkin
2020-04-21 14:45 ` Ani Sinha
2020-04-21 15:02 ` Daniel P. Berrangé [this message]
2020-04-22 10:45 ` Ani Sinha
2020-04-24 15:23 ` Ani Sinha
2020-04-24 18:44 ` Eduardo Habkost
2020-04-27 9:06 ` Ani Sinha
2020-04-29 15:32 ` Igor Mammedov
2020-05-10 17:42 ` Ani Sinha
2020-05-11 18:54 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421150201.GI479771@redhat.com \
--to=berrange@redhat.com \
--cc=ani.sinha@nutanix.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.