From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D86C6C54FC9 for ; Tue, 21 Apr 2020 17:39:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE83B206F4 for ; Tue, 21 Apr 2020 17:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587490796; bh=DeujCKaPmT9s1qf6BsHVmtgKDM79TE6c+FN9jrTESh8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CRWNCOWecrpKnf3IcsHxBENgQoM94A9DYfTjByjLvEc6Cn/H1c6c0x1kxq2ms4OFy GcRhYRB6VhyWSx6Tn1nymOXdsrx1GGsLljdaMi5gJLMKdvSuDKSnHEXyF0t1+C0/Pq UMSLheVAGjIBvbCIjy+qJdRFhGFxCNrfi18uatQ0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729277AbgDURj4 (ORCPT ); Tue, 21 Apr 2020 13:39:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:50242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729276AbgDURj4 (ORCPT ); Tue, 21 Apr 2020 13:39:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51036206D9; Tue, 21 Apr 2020 17:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587490795; bh=DeujCKaPmT9s1qf6BsHVmtgKDM79TE6c+FN9jrTESh8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=soY6fXk15JiN3nPLLPBjWErRD8kBhzIGjOv7YogW3LRXV7/HpsrEHzJIOe/s1ba3V w7bHVNprOWjchp2idrBsYnMSzoRcuqr0z5Mu3HQ66QjNmZWxCybKPL9Ot4T8mr5M/H +qmzOmC0VgYzqFBnqw3IEPtiZCzmbg5OAuHrhJdw= Date: Tue, 21 Apr 2020 19:39:53 +0200 From: Greg Kroah-Hartman To: Lee Jones Cc: stable@vger.kernel.org, "Gustavo A. R. Silva" , Todd Kjos , Martijn Coenen Subject: Re: [PATCH 4.14 06/24] android: binder: Use true and false for boolean values Message-ID: <20200421173953.GA1307291@kroah.com> References: <20200421124017.272694-1-lee.jones@linaro.org> <20200421124017.272694-7-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421124017.272694-7-lee.jones@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Apr 21, 2020 at 01:39:59PM +0100, Lee Jones wrote: > From: "Gustavo A. R. Silva" > > [ Upstream commit 197410ad884eb18b31d48e9d8e64cb5a9e326f2f ] > > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > Cc: Todd Kjos > Cc: Martijn Coenen > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Lee Jones > --- > drivers/android/binder.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > index 05e75d18b4d93..afb690ed31ed9 100644 > --- a/drivers/android/binder.c > +++ b/drivers/android/binder.c > @@ -249,7 +249,7 @@ static struct binder_transaction_log_entry *binder_transaction_log_add( > unsigned int cur = atomic_inc_return(&log->cur); > > if (cur >= ARRAY_SIZE(log->entry)) > - log->full = 1; > + log->full = true; While nice and pretty, this does not actually fix a bug, so it's not needed for stable trees. thanks, greg k-h