From: Rosen Penev <rosenp@gmail.com>
To: linux-media@vger.kernel.org
Subject: [PATCH 04/12] utils: don't check unsigned for < 0.
Date: Tue, 21 Apr 2020 17:37:27 -0700 [thread overview]
Message-ID: <20200422003735.3891-4-rosenp@gmail.com> (raw)
In-Reply-To: <20200422003735.3891-1-rosenp@gmail.com>
Found with -Wtautological-unsigned-zero-compare
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
utils/v4l2-compliance/v4l2-test-controls.cpp | 2 --
1 file changed, 2 deletions(-)
diff --git a/utils/v4l2-compliance/v4l2-test-controls.cpp b/utils/v4l2-compliance/v4l2-test-controls.cpp
index 8c4480be..251a6049 100644
--- a/utils/v4l2-compliance/v4l2-test-controls.cpp
+++ b/utils/v4l2-compliance/v4l2-test-controls.cpp
@@ -80,8 +80,6 @@ static int checkQCtrl(struct node *node, struct test_query_ext_ctrl &qctrl)
return fail("min > max\n");
if (qctrl.step == 0)
return fail("step == 0\n");
- if (qctrl.step < 0)
- return fail("step < 0\n");
if (static_cast<unsigned>(qctrl.step) > static_cast<unsigned>(qctrl.maximum - qctrl.minimum) &&
qctrl.maximum != qctrl.minimum)
return fail("step > max - min\n");
--
2.25.2
next prev parent reply other threads:[~2020-04-22 0:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 0:37 [PATCH 01/12] utils: fix compilation with C++98 Rosen Penev
2020-04-22 0:37 ` [PATCH 02/12] utils: remove extra commas Rosen Penev
2020-04-22 0:37 ` [PATCH 03/12] utils: fix float equal warning Rosen Penev
2020-04-22 0:37 ` Rosen Penev [this message]
2020-04-23 8:30 ` [PATCH 04/12] utils: don't check unsigned for < 0 Hans Verkuil
2020-04-23 8:33 ` Rosen Penev
2020-04-22 0:37 ` [PATCH 05/12] utils: add copy assignment operator Rosen Penev
2020-04-22 0:37 ` [PATCH 06/12] utils: add noreturn attribute and remove dead code Rosen Penev
2020-04-23 8:34 ` Hans Verkuil
2020-04-22 0:37 ` [PATCH 07/12] utils: fix implicit double promotion Rosen Penev
2020-04-23 9:04 ` Hans Verkuil
2020-04-22 0:37 ` [PATCH 08/12] utils: initialize variable Rosen Penev
2020-04-22 0:37 ` [PATCH 09/12] utils: fix implicit float conversions Rosen Penev
2020-04-23 8:36 ` Hans Verkuil
2020-04-23 8:44 ` Rosen Penev
2020-04-23 9:01 ` Hans Verkuil
2020-04-22 0:37 ` [PATCH 10/12] utils: fix fallthrough warnings Rosen Penev
2020-04-23 8:43 ` Hans Verkuil
2020-04-23 8:46 ` Rosen Penev
2020-04-23 8:57 ` Hans Verkuil
2020-04-22 0:37 ` [PATCH 11/12] utils: fix double promotions Rosen Penev
2020-04-23 8:45 ` Hans Verkuil
2020-04-22 0:37 ` [PATCH 12/12] utils: fix wrong format Rosen Penev
2020-04-23 8:19 ` [PATCH 01/12] utils: fix compilation with C++98 Hans Verkuil
2020-04-23 8:30 ` Rosen Penev
2020-04-23 8:48 ` Hans Verkuil
2020-04-23 8:50 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422003735.3891-4-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.