From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 2/8] perf metrics: fix parse errors in cascade lake metrics Date: Wed, 22 Apr 2020 07:38:40 -0700 Message-ID: <20200422143840.GJ608746@tassilo.jf.intel.com> References: <20200422074809.160248-1-irogers@google.com> <20200422074809.160248-3-irogers@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20200422074809.160248-3-irogers@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kan Liang , Haiyan Song , Jin Yao , Ravi Bangoria , John Garry , Leo Yan , Adrian Hunter , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Stephane Eranian List-Id: linux-perf-users.vger.kernel.org On Wed, Apr 22, 2020 at 12:48:03AM -0700, Ian Rogers wrote: > Remove over escaping with \\. > Remove extraneous if 1 if 0 == 1 else 0 else 0. So where do these parse errors happen exactly? Some earlier patches introduced them as regressions? The original metrics worked without parse errors as far as I know. If it fixes something earlier it would need Fixes: tags. -Andi