From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Alexey Krasikov <alex-krasikov@yandex-team.ru>
Cc: qemu-devel@nongnu.org, yc-core@yandex-team.ru
Subject: Re: [PATCH 1/2] crypto/secret: fix inconsequential errors.
Date: Wed, 22 Apr 2020 16:50:34 +0100 [thread overview]
Message-ID: <20200422155034.GI587120@redhat.com> (raw)
In-Reply-To: <20200415201336.24195-1-alex-krasikov@yandex-team.ru>
On Wed, Apr 15, 2020 at 11:13:35PM +0300, Alexey Krasikov wrote:
> * change condition from QCRYPTO_SECRET_FORMAT_RAW
> to QCRYPTO_SECRET_FORMAT_BASE64 in if-operator, because
> this is potencial error if you add another format value.
I'll drop the bullet point.
>
> Signed-off-by: Alexey Krasikov <alex-krasikov@yandex-team.ru>
> ---
> crypto/secret.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
and queued.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-04-22 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 20:13 [PATCH 1/2] crypto/secret: fix inconsequential errors Alexey Krasikov
2020-04-15 20:13 ` [PATCH 2/2] crypto/secret: fix return logic of crypto_secret_prop_get_loaded() Alexey Krasikov
2020-04-22 15:48 ` Daniel P. Berrangé
2020-04-22 15:50 ` Daniel P. Berrangé [this message]
2020-04-22 16:04 ` [PATCH 1/2] crypto/secret: fix inconsequential errors Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422155034.GI587120@redhat.com \
--to=berrange@redhat.com \
--cc=alex-krasikov@yandex-team.ru \
--cc=qemu-devel@nongnu.org \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.