From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jim Mattson <jmattson@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm list <kvm@vger.kernel.org>, Oliver Upton <oupton@google.com>,
Peter Shier <pshier@google.com>
Subject: Re: [PATCH 2/2] kvm: nVMX: Single-step traps trump expired VMX-preemption timer
Date: Wed, 22 Apr 2020 09:42:16 -0700 [thread overview]
Message-ID: <20200422164216.GB4662@linux.intel.com> (raw)
In-Reply-To: <CALMp9eR75_F6su19oMKeNU1NE4yPRGdNrxfHR+WskncRDSfvkg@mail.gmail.com>
On Wed, Apr 22, 2020 at 09:28:13AM -0700, Jim Mattson wrote:
> On Wed, Apr 22, 2020 at 1:30 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > On 14/04/20 02:09, Jim Mattson wrote:
> > > Previously, if the hrtimer for the nested VMX-preemption timer fired
> > > while L0 was emulating an L2 instruction with RFLAGS.TF set, the
> > > synthesized single-step trap would be unceremoniously dropped when
> > > synthesizing the "VMX-preemption timer expired" VM-exit from L2 to L1.
> > >
> > > To fix this, don't synthesize a "VMX-preemption timer expired" VM-exit
> > > from L2 to L1 when there is a pending debug trap, such as a
> > > single-step trap.
> >
> > Do you have a testcase for these bugs?
>
> Indeed. They should be just prior to this in your inbox.
Ah, I missed those too and apparently didn't think to search for preemption
timer tests. Thanks for the refresher!
next prev parent reply other threads:[~2020-04-22 16:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 0:09 [PATCH 1/2] kvm: nVMX: Pending debug exceptions trump expired VMX-preemption timer Jim Mattson
2020-04-14 0:09 ` [PATCH 2/2] kvm: nVMX: Single-step traps " Jim Mattson
2020-04-14 3:17 ` Sean Christopherson
2020-04-14 16:47 ` Jim Mattson
2020-04-15 0:12 ` Sean Christopherson
2020-04-15 0:20 ` Sean Christopherson
2020-04-15 0:22 ` Sean Christopherson
2020-04-15 23:33 ` Jim Mattson
2020-04-18 4:21 ` Sean Christopherson
2020-04-20 17:18 ` Jim Mattson
2020-04-21 4:41 ` Sean Christopherson
2020-04-21 18:28 ` Jim Mattson
2020-04-22 0:16 ` Sean Christopherson
2020-04-22 8:30 ` Paolo Bonzini
2020-04-22 15:48 ` Sean Christopherson
2020-04-22 16:28 ` Jim Mattson
2020-04-22 16:42 ` Sean Christopherson [this message]
2020-04-22 21:06 ` [PATCH 1/2] kvm: nVMX: Pending debug exceptions " Sean Christopherson
2020-04-22 21:23 ` Sean Christopherson
2020-04-22 21:27 ` Jim Mattson
2020-04-22 22:06 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422164216.GB4662@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.