From: Christoph Hellwig <hch@lst.de>
To: Martijn Coenen <maco@android.com>
Cc: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com,
narayan@google.com, zezeozue@google.com, kernel-team@android.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
maco@google.com, bvanassche@acm.org, Chaitanya.Kulkarni@wdc.com,
jaegeuk@kernel.org
Subject: Re: [PATCH v2 5/5] loop: Add LOOP_SET_FD_AND_STATUS ioctl
Date: Wed, 22 Apr 2020 19:44:31 +0200 [thread overview]
Message-ID: <20200422174431.GE30852@lst.de> (raw)
In-Reply-To: <20200422100636.46357-6-maco@android.com>
> + case LOOP_SET_FD: {
> + /* legacy case - pass in a zeroed out loop_info64, which
> + * corresponds with the default parameters we'd have used
> + * otherwise.
> + */
Nitpick: kernel coding style always has the /* on a line of its own.
Also please capitalize the first word in a multi-line comment.
> + struct loop_info64 info;
> +
> + memset(&info, 0, sizeof(info));
> + return loop_set_fd_and_status(lo, mode, bdev, arg, &info);
> + }
> + case LOOP_SET_FD_AND_STATUS: {
> + struct loop_fd_and_status fds;
> +
> + if (copy_from_user(&fds, argp, sizeof(fds)))
> + return -EFAULT;
> +
> + return loop_set_fd_and_status(lo, mode, bdev, fds.fd,
> + &fds.info);
What about actually passing the whole loop_fd_and_status structure?
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2020-04-22 17:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 10:06 [PATCH v2 0/5] Add a new LOOPSET_FD_AND_STATUS ioctl Martijn Coenen
2020-04-22 10:06 ` [PATCH v2 1/5] loop: Refactor size calculation Martijn Coenen
2020-04-22 17:39 ` Christoph Hellwig
2020-04-22 10:06 ` [PATCH v2 2/5] loop: Factor out configuring loop from status Martijn Coenen
2020-04-22 17:40 ` Christoph Hellwig
2020-04-22 10:06 ` [PATCH v2 3/5] loop: Move loop_set_status_from_info() and friends up Martijn Coenen
2020-04-22 17:40 ` Christoph Hellwig
2020-04-22 10:06 ` [PATCH v2 4/5] loop: rework lo_ioctl() __user argument casting Martijn Coenen
2020-04-22 17:41 ` Christoph Hellwig
2020-04-22 10:06 ` [PATCH v2 5/5] loop: Add LOOP_SET_FD_AND_STATUS ioctl Martijn Coenen
2020-04-22 17:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422174431.GE30852@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=maco@google.com \
--cc=ming.lei@redhat.com \
--cc=narayan@google.com \
--cc=zezeozue@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.