From: Borislav Petkov <bp@alien8.de>
To: Qian Cai <cai@lca.pw>
Cc: Christoph Hellwig <hch@lst.de>, Borislav Petkov <bp@suse.de>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
x86 <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>
Subject: Re: AMD boot woe due to "x86/mm: Cleanup pgprot_4k_2_large() and pgprot_large_2_4k()"
Date: Wed, 22 Apr 2020 23:47:51 +0200 [thread overview]
Message-ID: <20200422214751.GJ26846@zn.tnic> (raw)
In-Reply-To: <2568586B-B1F7-47F9-8B6F-6A4C0E5280A8@lca.pw>
On Wed, Apr 22, 2020 at 05:32:00PM -0400, Qian Cai wrote:
> This fixed the sucker,
>
> diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c
> index edf9cea4871f..c54d1d0a8e3b 100644
> --- a/arch/x86/mm/pgtable.c
> +++ b/arch/x86/mm/pgtable.c
> @@ -708,7 +708,7 @@ int pud_set_huge(pud_t *pud, phys_addr_t addr, pgprot_t prot)
>
> set_pte((pte_t *)pud, pfn_pte(
> (u64)addr >> PAGE_SHIFT,
> - __pgprot(protval_4k_2_large(pgprot_val(prot) | _PAGE_PSE))));
> + __pgprot(protval_4k_2_large(pgprot_val(prot)) | _PAGE_PSE)));
>
Very good catch - that's one nasty wrongly placed closing bracket!
pmd_set_huge() has it correct.
Mind sending a proper patch?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-04-22 21:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 15:55 AMD boot woe due to "x86/mm: Cleanup pgprot_4k_2_large() and pgprot_large_2_4k()" Qian Cai
2020-04-22 16:17 ` Borislav Petkov
2020-04-22 16:35 ` Qian Cai
2020-04-22 16:47 ` Borislav Petkov
2020-04-22 18:54 ` Qian Cai
2020-04-22 17:01 ` Christoph Hellwig
2020-04-22 18:35 ` Qian Cai
2020-04-22 21:32 ` Qian Cai
2020-04-22 21:47 ` Borislav Petkov [this message]
2020-04-22 21:57 ` Qian Cai
2020-04-22 22:05 ` Borislav Petkov
2020-04-23 6:08 ` Christoph Hellwig
2020-04-23 10:47 ` Qian Cai
2020-04-23 11:06 ` Boris Petkov
2020-04-23 11:21 ` Qian Cai
2020-04-23 12:22 ` Borislav Petkov
2020-04-23 12:26 ` [tip: x86/mm] x86/mm: Use pgprotval_t in protval_4k_2_large() and protval_large_2_4k() tip-bot2 for Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422214751.GJ26846@zn.tnic \
--to=bp@alien8.de \
--cc=bp@suse.de \
--cc=cai@lca.pw \
--cc=hch@lst.de \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.