From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.garry@huawei.com>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.com>, Christoph Hellwig <hch@lst.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH V7 4/9] blk-mq: support rq filter callback when iterating rqs
Date: Thu, 23 Apr 2020 09:31:59 +0200 [thread overview]
Message-ID: <20200423073159.GD10951@lst.de> (raw)
In-Reply-To: <02c79673-44d8-16b6-bd45-93b7b8467497@huawei.com>
On Mon, Apr 20, 2020 at 11:34:11AM +0100, John Garry wrote:
>> EXPORT_SYMBOL(blk_mq_tagset_busy_iter);
>> diff --git a/block/blk-mq-tag.h b/block/blk-mq-tag.h
>> index 2b8321efb682..fdf095d513e5 100644
>> --- a/block/blk-mq-tag.h
>> +++ b/block/blk-mq-tag.h
>> @@ -21,6 +21,7 @@ struct blk_mq_tags {
>> struct list_head page_list;
>> };
>> +typedef bool (busy_rq_iter_fn)(struct request *, void *, bool);
>> extern struct blk_mq_tags *blk_mq_init_tags(unsigned int nr_tags,
>> unsigned int reserved_tags, int node, int alloc_policy);
>> extern void blk_mq_free_tags(struct blk_mq_tags *tags);
>> @@ -34,6 +35,9 @@ extern int blk_mq_tag_update_depth(struct blk_mq_hw_ctx *hctx,
>> extern void blk_mq_tag_wakeup_all(struct blk_mq_tags *tags, bool);
>> void blk_mq_queue_tag_busy_iter(struct request_queue *q, busy_iter_fn *fn,
>> void *priv);
>> +void blk_mq_all_tag_busy_iter(struct blk_mq_tags *tags,
>> + busy_tag_iter_fn *fn, busy_rq_iter_fn *busy_rq_fn,
>> + void *priv);
>
> Could you please pay attention to alignment of the arguments and the
> opening brace? This patchset fails that in many places.
Mings patch use the perfectly fine two tab alignment, which in many
ways is much easier to deal with than the weird brace alignment.
next prev parent reply other threads:[~2020-04-23 7:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 3:09 [PATCH V7 0/9] blk-mq: improvement CPU hotplug Ming Lei
2020-04-18 3:09 ` [PATCH V7 1/9] blk-mq: mark blk_mq_get_driver_tag as static Ming Lei
2020-04-23 7:14 ` Christoph Hellwig
2020-04-18 3:09 ` [PATCH V7 2/9] blk-mq: assign rq->tag in blk_mq_get_driver_tag Ming Lei
2020-04-23 7:30 ` Christoph Hellwig
2020-04-18 3:09 ` [PATCH V7 3/9] blk-mq: prepare for draining IO when hctx's all CPUs are offline Ming Lei
2020-04-23 7:31 ` Christoph Hellwig
2020-04-18 3:09 ` [PATCH V7 4/9] blk-mq: support rq filter callback when iterating rqs Ming Lei
2020-04-20 10:34 ` John Garry
2020-04-23 7:31 ` Christoph Hellwig [this message]
2020-04-23 7:32 ` Christoph Hellwig
2020-04-18 3:09 ` [PATCH V7 5/9] blk-mq: stop to handle IO and drain IO before hctx becomes inactive Ming Lei
2020-04-23 7:38 ` Christoph Hellwig
2020-04-18 3:09 ` [PATCH V7 6/9] block: add blk_end_flush_machinery Ming Lei
2020-04-23 7:40 ` Christoph Hellwig
2020-04-18 3:09 ` [PATCH V7 7/9] blk-mq: re-submit IO in case that hctx is inactive Ming Lei
2020-04-23 7:50 ` Christoph Hellwig
2020-04-23 8:46 ` Ming Lei
2020-04-18 3:09 ` [PATCH V7 8/9] blk-mq: handle requests dispatched from IO scheduler in case of inactive hctx Ming Lei
2020-04-23 7:51 ` Christoph Hellwig
2020-04-18 3:09 ` [PATCH V7 9/9] block: deactivate hctx when the hctx is actually inactive Ming Lei
2020-04-20 10:29 ` [PATCH V7 0/9] blk-mq: improvement CPU hotplug John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423073159.GD10951@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.com \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.