From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oscar Carter <oscar.carter@gmx.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
Quentin Deslandes <quentin.deslandes@itdev.co.uk>,
Malcolm Priestley <tvboxspy@gmail.com>,
Amir Mahdi Ghorbanian <indigoomega021@gmail.com>,
Stefano Brivio <sbrivio@redhat.com>,
"John B. Wyatt IV" <jbwyatt4@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] staging: vt6656: Check the return value of vnt_control_out_* calls
Date: Thu, 23 Apr 2020 13:40:32 +0200 [thread overview]
Message-ID: <20200423114032.GA3838948@kroah.com> (raw)
In-Reply-To: <20200419104821.6127-2-oscar.carter@gmx.com>
On Sun, Apr 19, 2020 at 12:48:20PM +0200, Oscar Carter wrote:
> Check the return value of vnt_control_out_* function calls. When
> necessary modify the function prototype to be able to return the new
> checked error code.
>
> It's safe to modify all the function prototypes without fix the call
> because the only change is the return value from void to int. If before
> the call didn't check the return value, now neither.
>
> Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
This patch, and the 2/2 patch did not apply to my tree. Can you please
rebase and resend?
thanks,
greg k-h
next prev parent reply other threads:[~2020-04-23 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 10:48 [PATCH v2 0/2] staging: vt6656: Check the return value of vnt_control_out_* calls Oscar Carter
2020-04-19 10:48 ` [PATCH v2 1/2] " Oscar Carter
2020-04-23 11:40 ` Greg Kroah-Hartman [this message]
2020-04-23 15:08 ` Oscar Carter
2020-04-19 10:48 ` [PATCH v2 2/2] staging: vt6656: Remove functions' documentation Oscar Carter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423114032.GA3838948@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=indigoomega021@gmail.com \
--cc=jbwyatt4@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oscar.carter@gmx.com \
--cc=quentin.deslandes@itdev.co.uk \
--cc=sbrivio@redhat.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.