From: Wolfram Sang <wsa@the-dreams.de>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Takeshi Saito <takeshi.saito.xv@renesas.com>
Subject: Re: [PATCH 2/2] mmc: renesas_sdhi: avoid bad TAP in HS400
Date: Thu, 23 Apr 2020 14:19:29 +0200 [thread overview]
Message-ID: <20200423121929.GA1130@ninjato> (raw)
In-Reply-To: <TYAPR01MB45448C2024C50BF3FB6B7EF9D8D30@TYAPR01MB4544.jpnprd01.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
> > + if (bad_taps & BIT(new_tap)) {
> > + new_tap = (priv->tap_set - 1) % priv->tap_num;
> > + }
>
> I think we can remove the braces.
> After removed it,
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
True. Thank you, Shimoda-san!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-04-23 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 12:59 [PATCH 0/2] mmc: renesas_sdhi: avoid bad TAPs for Gen3 Wolfram Sang
2020-04-22 12:59 ` [PATCH 1/2] mmc: renesas_sdhi: handle M3-N ES1.2 and 1.3 revisions Wolfram Sang
2020-04-23 10:31 ` Yoshihiro Shimoda
2020-04-22 12:59 ` [PATCH 2/2] mmc: renesas_sdhi: avoid bad TAP in HS400 Wolfram Sang
2020-04-23 10:41 ` Yoshihiro Shimoda
2020-04-23 12:19 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423121929.GA1130@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=takeshi.saito.xv@renesas.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.