From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F931C54FD0 for ; Thu, 23 Apr 2020 17:14:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1143520857 for ; Thu, 23 Apr 2020 17:14:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Fh0fZr67" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729783AbgDWROj (ORCPT ); Thu, 23 Apr 2020 13:14:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729768AbgDWROj (ORCPT ); Thu, 23 Apr 2020 13:14:39 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB6A7C09B044 for ; Thu, 23 Apr 2020 10:14:38 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id mq3so2772899pjb.1 for ; Thu, 23 Apr 2020 10:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ImuquuX0o7pPZ9bGea3cOCMdcWyQffNkeX4qWUmGnVg=; b=Fh0fZr67sNv4FZXbdb2Lcuj0w/6m5469ARU5b3Jv/J3awFsgvnHW3GBDZFtirwtTBQ VEnYdEMOXA7GOEJ772QwCTyKtnMRkhQGc274PhNw5eueSePwxSpYDaiovIpiQwbjJpk7 A+JstF5rX7YaXE7oR/EIxsG2+WhCAhxk2uvkY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ImuquuX0o7pPZ9bGea3cOCMdcWyQffNkeX4qWUmGnVg=; b=MvsYOM3w/HhHKQSOwqI53H0S/C7rkZonXwyK4+C447+rxD3gUoNi/+dRWK20q+U9+M IVZoEV6IHlo1hP8r/kLeLMks4HnJ0uCmaOyRvUNJ1BJo8hgq44X0YJI09PftMjLOMg4V nZAAEZ58YC2q3pwf9h/uS+8AoBOZXGzYwQC9zUYUwDkb3TAzmH5uhFtsyqkfDupC8JJ/ 9ELNI5pKUzTUme6UaXxEGYAHLvcTBkEPiYjnoEDgF3myea+M7RHNCwygNJB4ORD922Vd 6HRtkSOzy8XNFwbCdpEbRlZbU2adFmPcam23SPQLnvk0vmzXKZxk4BATmC3Jd3DRAeeH aGog== X-Gm-Message-State: AGi0PuaBTrUxBiY7l/EAfdpZPdPGxv3USuRDl8V6c0XF3aSwOqoULQxp 6CD3muqL0t5/X0iFGm4dWtRnpw== X-Google-Smtp-Source: APiQypIk9MvasGQWk+XnO6jWjIG+YouGIGQ62gjIE7RPw9r/JY+62QVCBe9Tpk5sU4R2pFA0IkyAPQ== X-Received: by 2002:a17:902:70c1:: with SMTP id l1mr4519146plt.298.1587662078207; Thu, 23 Apr 2020 10:14:38 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id d12sm2950227pfq.36.2020.04.23.10.14.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2020 10:14:37 -0700 (PDT) Date: Thu, 23 Apr 2020 10:14:36 -0700 From: Matthias Kaehlcke To: Stephen Boyd Cc: Andy Gross , Bjorn Andersson , Doug Anderson , Kishon Vijay Abraham I , Mark Rutland , Rob Herring , Sandeep Maheswaram , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Manu Gautam , Tanmay Shah , robdclark@gmail.com, abhinavk@codeaurora.org, nganji@codeaurora.org, jsanka@codeaurora.org, aravindh@codeaurora.org, hoegsberg@google.com, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v5 1/3] dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml Message-ID: <20200423171436.GJ199755@google.com> References: <1585809534-11244-1-git-send-email-sanm@codeaurora.org> <1585809534-11244-2-git-send-email-sanm@codeaurora.org> <158689927748.105027.5367465616284167712@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <158689927748.105027.5367465616284167712@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Sandeep, On Tue, Apr 14, 2020 at 02:21:17PM -0700, Stephen Boyd wrote: > Quoting Sandeep Maheswaram (2020-04-01 23:38:52) > > Convert QMP PHY bindings to DT schema format using json-schema. > > > > Signed-off-by: Sandeep Maheswaram > > --- > > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 332 +++++++++++++++++++++ > > .../devicetree/bindings/phy/qcom-qmp-phy.txt | 242 --------------- > > 2 files changed, 332 insertions(+), 242 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > delete mode 100644 Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > new file mode 100644 > > index 0000000..18a8985 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > @@ -0,0 +1,332 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > + > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/phy/qcom,qmp-phy.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Qualcomm QMP PHY controller > > + > > +maintainers: > > + - Manu Gautam > > + > > +description: > > + QMP phy controller supports physical layer functionality for a number of > > + controllers on Qualcomm chipsets, such as, PCIe, UFS, and USB. > > + > > +properties: > > + compatible: > > + enum: > > + - qcom,ipq8074-qmp-pcie-phy > > + - qcom,msm8996-qmp-pcie-phy > > + - qcom,msm8996-qmp-ufs-phy > > + - qcom,msm8996-qmp-usb3-phy > > + - qcom,msm8998-qmp-pcie-phy > > + - qcom,msm8998-qmp-ufs-phy > > + - qcom,msm8998-qmp-usb3-phy > > + - qcom,sdm845-qhp-pcie-phy > > + - qcom,sdm845-qmp-pcie-phy > > + - qcom,sdm845-qmp-ufs-phy > > + - qcom,sdm845-qmp-usb3-phy > > + - qcom,sdm845-qmp-usb3-uni-phy > > + - qcom,sm8150-qmp-ufs-phy > > + > > + reg: > > + minItems: 1 > > + items: > > + - description: Address and length of PHY's common serdes block. > > + - description: Address and length of the DP_COM control block. > > This DP_COM block is only for one compatible. Is it possible to split > that compatible out of this binding so we can enforce the reg property > being either one or two items? > > In addition, I don't quite understand how this binding is supposed to > work with the DP phy that sits inside qcom,sdm845-qmp-usb3-phy and then > gets muxed out on the USB pins on sdm845 and sc7180 SoCs. Can you fill > me in on how we plan to share the pins between the two phys so that all > the combinations of DP and USB over the type-c pins will work here? My > understanding is that the pins that are controlled by this hardware > block are basically a full USB type-c connector pinout[1] (except that > D+/D- isn't there and the VBUS and CC lines go to the PMIC). Either way, > we get the TX1/2 and RX1/2 pins to use, so we can do 4x lanes of DP or > 2x lanes DP and 2x lanes of USB. There's also a type-c orientation > flipper bit that can flip the DP and USB phy lanes to the correct TX/RX > pins on the SoC. And then the DP phy has a lane remapper to change the > logical DP lane to the physical DP lane. It's a complex piece of > hardware that isn't fully represented by this binding. > > [1] https://en.wikipedia.org/wiki/USB-C#/media/File:USB_Type-C_Receptacle_Pinout.svg Could you please answer Stephen's questions? It would be great to move forward and get support for SC7180 landed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4140AC55191 for ; Thu, 23 Apr 2020 17:14:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0831320728 for ; Thu, 23 Apr 2020 17:14:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Fh0fZr67" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0831320728 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 75ABB6E4F3; Thu, 23 Apr 2020 17:14:40 +0000 (UTC) Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by gabe.freedesktop.org (Postfix) with ESMTPS id A50D36E4F3 for ; Thu, 23 Apr 2020 17:14:38 +0000 (UTC) Received: by mail-pl1-x641.google.com with SMTP id t16so2601912plo.7 for ; Thu, 23 Apr 2020 10:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ImuquuX0o7pPZ9bGea3cOCMdcWyQffNkeX4qWUmGnVg=; b=Fh0fZr67sNv4FZXbdb2Lcuj0w/6m5469ARU5b3Jv/J3awFsgvnHW3GBDZFtirwtTBQ VEnYdEMOXA7GOEJ772QwCTyKtnMRkhQGc274PhNw5eueSePwxSpYDaiovIpiQwbjJpk7 A+JstF5rX7YaXE7oR/EIxsG2+WhCAhxk2uvkY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ImuquuX0o7pPZ9bGea3cOCMdcWyQffNkeX4qWUmGnVg=; b=YdHCfcUj1b7+zpx0D3z+ZfFGBnnpR5Rc9Sh3bTRWe4WISHit94jIoUYTNTvbtEO+VT u/gaWO6pQlP5Kq00+C5DenJWrOWz2bJdypKlbH15BDd+zQajF1HSuM8DDGxrrp/0EwqS jH0P6bnGgP5qDEizb3udTfouWct8HjsplxZ1GwOwMw1VPj8k1HXMjPMBeo8r473LIbB9 N8YJuUXo3cCMHtlV+B6oSqu7cupddlB960NYfTOvxfaA5kc5qtMjf7zUxia5p2pzO39Z Rfcl8MW7L/2MytCOEIlKDeLvjNTSpqBPpnQuH/W2VQa4l2CnYWuHtSF8MOTbbVGHGM/j l6Ng== X-Gm-Message-State: AGi0PubYIs5En7M5MFLH6ZSfJdVVva2p9GlZujvSHrSMMV5P7KjUyAdg bVLmJ1j9mTAxTa9TFFKSew1kFQ== X-Google-Smtp-Source: APiQypIk9MvasGQWk+XnO6jWjIG+YouGIGQ62gjIE7RPw9r/JY+62QVCBe9Tpk5sU4R2pFA0IkyAPQ== X-Received: by 2002:a17:902:70c1:: with SMTP id l1mr4519146plt.298.1587662078207; Thu, 23 Apr 2020 10:14:38 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id d12sm2950227pfq.36.2020.04.23.10.14.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2020 10:14:37 -0700 (PDT) Date: Thu, 23 Apr 2020 10:14:36 -0700 From: Matthias Kaehlcke To: Stephen Boyd Subject: Re: [PATCH v5 1/3] dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml Message-ID: <20200423171436.GJ199755@google.com> References: <1585809534-11244-1-git-send-email-sanm@codeaurora.org> <1585809534-11244-2-git-send-email-sanm@codeaurora.org> <158689927748.105027.5367465616284167712@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <158689927748.105027.5367465616284167712@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, aravindh@codeaurora.org, Sandeep Maheswaram , dri-devel@lists.freedesktop.org, abhinavk@codeaurora.org, Doug Anderson , Rob Herring , Kishon Vijay Abraham I , Manu Gautam , Andy Gross , hoegsberg@google.com, Tanmay Shah , linux-arm-msm@vger.kernel.org, Bjorn Andersson , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sandeep, On Tue, Apr 14, 2020 at 02:21:17PM -0700, Stephen Boyd wrote: > Quoting Sandeep Maheswaram (2020-04-01 23:38:52) > > Convert QMP PHY bindings to DT schema format using json-schema. > > > > Signed-off-by: Sandeep Maheswaram > > --- > > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 332 +++++++++++++++++++++ > > .../devicetree/bindings/phy/qcom-qmp-phy.txt | 242 --------------- > > 2 files changed, 332 insertions(+), 242 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > delete mode 100644 Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > new file mode 100644 > > index 0000000..18a8985 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > @@ -0,0 +1,332 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > + > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/phy/qcom,qmp-phy.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Qualcomm QMP PHY controller > > + > > +maintainers: > > + - Manu Gautam > > + > > +description: > > + QMP phy controller supports physical layer functionality for a number of > > + controllers on Qualcomm chipsets, such as, PCIe, UFS, and USB. > > + > > +properties: > > + compatible: > > + enum: > > + - qcom,ipq8074-qmp-pcie-phy > > + - qcom,msm8996-qmp-pcie-phy > > + - qcom,msm8996-qmp-ufs-phy > > + - qcom,msm8996-qmp-usb3-phy > > + - qcom,msm8998-qmp-pcie-phy > > + - qcom,msm8998-qmp-ufs-phy > > + - qcom,msm8998-qmp-usb3-phy > > + - qcom,sdm845-qhp-pcie-phy > > + - qcom,sdm845-qmp-pcie-phy > > + - qcom,sdm845-qmp-ufs-phy > > + - qcom,sdm845-qmp-usb3-phy > > + - qcom,sdm845-qmp-usb3-uni-phy > > + - qcom,sm8150-qmp-ufs-phy > > + > > + reg: > > + minItems: 1 > > + items: > > + - description: Address and length of PHY's common serdes block. > > + - description: Address and length of the DP_COM control block. > > This DP_COM block is only for one compatible. Is it possible to split > that compatible out of this binding so we can enforce the reg property > being either one or two items? > > In addition, I don't quite understand how this binding is supposed to > work with the DP phy that sits inside qcom,sdm845-qmp-usb3-phy and then > gets muxed out on the USB pins on sdm845 and sc7180 SoCs. Can you fill > me in on how we plan to share the pins between the two phys so that all > the combinations of DP and USB over the type-c pins will work here? My > understanding is that the pins that are controlled by this hardware > block are basically a full USB type-c connector pinout[1] (except that > D+/D- isn't there and the VBUS and CC lines go to the PMIC). Either way, > we get the TX1/2 and RX1/2 pins to use, so we can do 4x lanes of DP or > 2x lanes DP and 2x lanes of USB. There's also a type-c orientation > flipper bit that can flip the DP and USB phy lanes to the correct TX/RX > pins on the SoC. And then the DP phy has a lane remapper to change the > logical DP lane to the physical DP lane. It's a complex piece of > hardware that isn't fully represented by this binding. > > [1] https://en.wikipedia.org/wiki/USB-C#/media/File:USB_Type-C_Receptacle_Pinout.svg Could you please answer Stephen's questions? It would be great to move forward and get support for SC7180 landed. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel