From: Bjorn Helgaas <helgaas@kernel.org>
To: Ani Sinha <ani@anisinha.ca>
Cc: linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Keith Busch <keith.busch@intel.com>,
Frederick Lawler <fred@fredlawl.com>,
Denis Efremov <efremov@linux.com>,
Alexandru Gagniuc <mr.nuke.me@gmail.com>,
Lukas Wunner <lukas@wunner.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: pciehp: Cleanup unused EMI() and HP_SUPR_RM() macros
Date: Thu, 23 Apr 2020 13:47:32 -0500 [thread overview]
Message-ID: <20200423184732.GA203039@google.com> (raw)
In-Reply-To: <1587439673-39652-1-git-send-email-ani@anisinha.ca>
On Tue, Apr 21, 2020 at 08:57:50AM +0530, Ani Sinha wrote:
> We do not use PCIE hotplug surprise (PCI_EXP_SLTCAP_HPS) bit anymore.
> Consequently HP_SUPR_RM() macro is no longer used. Let's clean it up.
> EMI() macro also seems to be unused. So removing it as well. Thanks
> Mika Westerberg <mika.westerberg@linux.intel.com> for
> pointing it out.
>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Applied to pci/hotplug for v5.8, thanks!
> ---
> drivers/pci/hotplug/pciehp.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/pciehp.h b/drivers/pci/hotplug/pciehp.h
> index ae44f46..4fd200d 100644
> --- a/drivers/pci/hotplug/pciehp.h
> +++ b/drivers/pci/hotplug/pciehp.h
> @@ -148,8 +148,6 @@ struct controller {
> #define MRL_SENS(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_MRLSP)
> #define ATTN_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_AIP)
> #define PWR_LED(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_PIP)
> -#define HP_SUPR_RM(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_HPS)
> -#define EMI(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_EIP)
> #define NO_CMD_CMPL(ctrl) ((ctrl)->slot_cap & PCI_EXP_SLTCAP_NCCS)
> #define PSN(ctrl) (((ctrl)->slot_cap & PCI_EXP_SLTCAP_PSN) >> 19)
>
> --
> 2.7.4
>
prev parent reply other threads:[~2020-04-23 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 3:27 [PATCH] PCI: pciehp: Cleanup unused EMI() and HP_SUPR_RM() macros Ani Sinha
2020-04-23 18:47 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423184732.GA203039@google.com \
--to=helgaas@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=ani@anisinha.ca \
--cc=efremov@linux.com \
--cc=fred@fredlawl.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=mr.nuke.me@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.