All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] nfsd4: stid display should preserve on-the-wire byte order
Date: Thu, 23 Apr 2020 16:49:29 -0400	[thread overview]
Message-ID: <20200423204929.GA11239@pick.fieldses.org> (raw)
In-Reply-To: <1587674073-9551-2-git-send-email-bfields@redhat.com>

By the way, one other thing I noticed, in the "states" file there's a
field like:

	superblock: "fd:10:114"

That's major:minor:inode number, which is the same thing /proc/locks
uses to identify files.  "superblock" makes sense for the "major:minor"
part, but the inode number is for the one file, not the superblock.  So
that probably should have been

	superblock: "fd:10:114", inode: 114

or something.  Oh well.  It's been that way in a few kernel versions now
so I guess it's not worth breaking backwards compatibility.

--b.


  reply	other threads:[~2020-04-23 20:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 20:34 [PATCH 1/2] nfsd4: common stateid-printing code J. Bruce Fields
2020-04-23 20:34 ` [PATCH 2/2] nfsd4: stid display should preserve on-the-wire byte order J. Bruce Fields
2020-04-23 20:49   ` J. Bruce Fields [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-05-11 23:17 [PATCH 1/2] nfsd4: common stateid-printing code J. Bruce Fields
2020-05-11 23:17 ` [PATCH 2/2] nfsd4: stid display should preserve on-the-wire byte order J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200423204929.GA11239@pick.fieldses.org \
    --to=bfields@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.