All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: shengjiu.wang@nxp.com
Cc: alsa-devel@alsa-project.org
Subject: [bug report] ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers
Date: Fri, 24 Apr 2020 13:20:08 +0300	[thread overview]
Message-ID: <20200424102008.GA414495@mwanda> (raw)

Hello Shengjiu Wang,

This is a semi-automatic email about new static checker warnings.

The patch 955ac624058f: "ASoC: fsl_easrc: Add EASRC ASoC CPU DAI
drivers" from Apr 16, 2020, leads to the following Smatch complaint:

    sound/soc/fsl/fsl_easrc.c:1529 fsl_easrc_hw_free()
    warn: variable dereferenced before check 'ctx' (see line 1527)

sound/soc/fsl/fsl_easrc.c
  1526		struct fsl_asrc_pair *ctx = runtime->private_data;
  1527		struct fsl_easrc_ctx_priv *ctx_priv = ctx->private;
                                                      ^^^^^
Dereference

  1528	
  1529		if (ctx && (ctx_priv->ctx_streams & BIT(substream->stream))) {
                    ^^^
This check is too late, to prevent a NULL dereference.

  1530			ctx_priv->ctx_streams &= ~BIT(substream->stream);
  1531			fsl_easrc_release_context(ctx);

regards,
dan carpenter

                 reply	other threads:[~2020-04-24 10:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200424102008.GA414495@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.