From: Stephan Gerhold <stephan@gerhold.net>
To: Andi Shyti <andi@etezian.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: mms114 - add extra compatible for mms345l
Date: Fri, 24 Apr 2020 13:34:46 +0200 [thread overview]
Message-ID: <20200424113446.GA205913@gerhold.net> (raw)
In-Reply-To: <20200424092937.GB460760@jack.zhora.eu>
On Fri, Apr 24, 2020 at 12:29:37PM +0300, Andi Shyti wrote:
> Hi guys,
>
> > }, {
> > .compatible = "melfas,mms152",
> > .data = (void *)TYPE_MMS152,
> > + }, {
> > + .compatible = "melfas,mms345l",
> > + .data = (void *)TYPE_MMS345L,
> > },
>
> it's been some times I haven't been doing this, but is the order
> of the patches correct? shouldn't the binding be updated first?
>
Yes. I had it correct in my original patch, but apparently swapped the
order accidentally for this one. I will do it correct again next time :)
Thanks,
Stephan
next prev parent reply other threads:[~2020-04-24 11:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 10:24 [PATCH 1/2] Input: mms114 - add extra compatible for mms345l Stephan Gerhold
2020-04-23 10:24 ` [PATCH 2/2] dt-bindings: mms114: document melfas,mms345l binding Stephan Gerhold
2020-04-25 20:06 ` Dmitry Torokhov
2020-04-24 9:29 ` [PATCH 1/2] Input: mms114 - add extra compatible for mms345l Andi Shyti
2020-04-24 11:34 ` Stephan Gerhold [this message]
2020-04-24 13:22 ` Andi Shyti
2020-04-25 18:24 ` Stephan Gerhold
2020-04-25 20:07 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424113446.GA205913@gerhold.net \
--to=stephan@gerhold.net \
--cc=andi@etezian.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.