All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com, berto@igalia.com,
	qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [PATCH v7 00/10] block: Fix resize (extending) of short overlays
Date: Fri, 24 Apr 2020 14:54:38 +0200	[thread overview]
Message-ID: <20200424125448.63318-1-kwolf@redhat.com> (raw)

v7:
- Allocate smaller zero buffer [Vladimir]
- Added missing error_setg_errno() [Max]
- Code cleanup in the iotest, enabled mapping for 'metadata' [Vladimir]
- Don't assign to errp twice [Eric]

v6:
- qcow2: Don't round up end offset [Eric]
- qcow2: Use different error messages for different error paths
- Request BDRV_REQ_ZERO_WRITE only if the backing file actually covers
  (part of) the new area (fix regression from v3) [Max]
- New patch: Forward ZERO_WRITE flag for full preallocation [Max]

v5:
- Fixed file-win32 [Patchew]
- Fixed zeroing in qcow2 for unaligned requests + tests [Vladimir]
- Made raw-format code more consistent [Eric]
- Leave output for existing iotests cases unchanged [Vladimir]

v4:
- Rewrote the series to move the actual zeroing to the block drivers so
  that error paths can work correctly and potentially long-running
  fallback to writing explicit zeroes is avoided.
- Fixed output filtering order in the test case [Max]

v3:
- Don't allow blocking the monitor for a zero write in block_resize
  (even though we can already blockfor other reasons there). This is
  mainly responsible for the increased complexity compared to v2.
  Personally, I think this is not an improvement over v2, but if this is
  what it takes to fix a corruption issue in 4.2... [Max]
- Don't use huge image files in the test case [Vladimir]

v2:
- Switched order of bs->total_sectors update and zero write [Vladimir]
- Fixed coding style [Vladimir]
- Changed the commit message to contain what was in the cover letter
- Test all preallocation modes
- Test allocation status with qemu-io 'map' [Vladimir]

Kevin Wolf (10):
  block: Add flags to BlockDriver.bdrv_co_truncate()
  block: Add flags to bdrv(_co)_truncate()
  block-backend: Add flags to blk_truncate()
  qcow2: Support BDRV_REQ_ZERO_WRITE for truncate
  raw-format: Support BDRV_REQ_ZERO_WRITE for truncate
  file-posix: Support BDRV_REQ_ZERO_WRITE for truncate
  block: truncate: Don't make backing file data visible
  iotests: Filter testfiles out in filter_img_info()
  iotests: Test committing to short backing file
  qcow2: Forward ZERO_WRITE flag for full preallocation

 include/block/block.h          |   5 +-
 include/block/block_int.h      |  10 +-
 include/sysemu/block-backend.h |   2 +-
 block.c                        |   3 +-
 block/block-backend.c          |   4 +-
 block/commit.c                 |   4 +-
 block/crypto.c                 |   7 +-
 block/file-posix.c             |   6 +-
 block/file-win32.c             |   2 +-
 block/gluster.c                |   1 +
 block/io.c                     |  43 +++++-
 block/iscsi.c                  |   2 +-
 block/mirror.c                 |   2 +-
 block/nfs.c                    |   3 +-
 block/parallels.c              |   6 +-
 block/qcow.c                   |   4 +-
 block/qcow2-cluster.c          |   2 +-
 block/qcow2-refcount.c         |   2 +-
 block/qcow2.c                  |  73 +++++++--
 block/qed.c                    |   3 +-
 block/raw-format.c             |   6 +-
 block/rbd.c                    |   1 +
 block/sheepdog.c               |   4 +-
 block/ssh.c                    |   2 +-
 block/vdi.c                    |   2 +-
 block/vhdx-log.c               |   2 +-
 block/vhdx.c                   |   6 +-
 block/vmdk.c                   |   8 +-
 block/vpc.c                    |   2 +-
 blockdev.c                     |   2 +-
 qemu-img.c                     |   2 +-
 qemu-io-cmds.c                 |   2 +-
 tests/test-block-iothread.c    |   9 +-
 tests/qemu-iotests/iotests.py  |   5 +-
 tests/qemu-iotests/274         | 155 +++++++++++++++++++
 tests/qemu-iotests/274.out     | 268 +++++++++++++++++++++++++++++++++
 tests/qemu-iotests/group       |   1 +
 37 files changed, 597 insertions(+), 64 deletions(-)
 create mode 100755 tests/qemu-iotests/274
 create mode 100644 tests/qemu-iotests/274.out

-- 
2.25.3



             reply	other threads:[~2020-04-24 12:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 12:54 Kevin Wolf [this message]
2020-04-24 12:54 ` [PATCH v7 01/10] block: Add flags to BlockDriver.bdrv_co_truncate() Kevin Wolf
2020-04-24 12:54 ` [PATCH v7 02/10] block: Add flags to bdrv(_co)_truncate() Kevin Wolf
2020-04-24 12:54 ` [PATCH v7 03/10] block-backend: Add flags to blk_truncate() Kevin Wolf
2020-04-24 12:54 ` [PATCH v7 04/10] qcow2: Support BDRV_REQ_ZERO_WRITE for truncate Kevin Wolf
2020-04-24 14:07   ` Max Reitz
2020-04-24 14:39   ` Eric Blake
2020-04-28 16:28   ` Eric Blake
2020-04-28 18:45     ` Kevin Wolf
2020-04-28 18:58       ` Eric Blake
2020-04-24 12:54 ` [PATCH v7 05/10] raw-format: " Kevin Wolf
2020-04-24 12:54 ` [PATCH v7 06/10] file-posix: " Kevin Wolf
2020-04-24 12:54 ` [PATCH v7 07/10] block: truncate: Don't make backing file data visible Kevin Wolf
2020-04-24 14:09   ` Max Reitz
2020-04-24 12:54 ` [PATCH v7 08/10] iotests: Filter testfiles out in filter_img_info() Kevin Wolf
2020-04-24 12:54 ` [PATCH v7 09/10] iotests: Test committing to short backing file Kevin Wolf
2020-04-24 14:14   ` Max Reitz
2020-04-24 14:49   ` Vladimir Sementsov-Ogievskiy
2020-04-24 14:16 ` [PATCH v7 00/10] block: Fix resize (extending) of short overlays Max Reitz
2020-04-24 14:27 ` [PATCH v7 10/10] qcow2: Forward ZERO_WRITE flag for full preallocation Kevin Wolf
2020-04-24 14:28   ` Max Reitz
2020-04-24 15:26   ` Vladimir Sementsov-Ogievskiy
2020-04-27 15:43 ` [PATCH v7 00/10] block: Fix resize (extending) of short overlays Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200424125448.63318-1-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=berto@igalia.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.