From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33CC4C54FD0 for ; Fri, 24 Apr 2020 20:51:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F01520857 for ; Fri, 24 Apr 2020 20:51:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F01520857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 980FD6EB08; Fri, 24 Apr 2020 20:51:45 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62AC76EB08 for ; Fri, 24 Apr 2020 20:51:44 +0000 (UTC) IronPort-SDR: xEYgXOEXKVVB2Ba0p6kfbDczcHNkztcZkFd+uUZgio+NFuZg2VFM5+cYzZjJVjV5CwkxfaPkTU wCE8G9PMIC5A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2020 13:51:43 -0700 IronPort-SDR: KmZKfq1/8otp/SovROwCZHUwUvK8gEkg+DOK1JXYLjp31khfOtw7+DIQak9wawGiOcp+6RjVA/ h3s7pH+toIJg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,313,1583222400"; d="scan'208";a="335482470" Received: from mlandows-mobl.ger.corp.intel.com (HELO intel.com) ([10.252.12.15]) by orsmga001.jf.intel.com with ESMTP; 24 Apr 2020 13:51:41 -0700 Date: Fri, 24 Apr 2020 23:51:40 +0300 From: Andi Shyti To: Chris Wilson Message-ID: <20200424205140.GB1429@intel.intel> References: <20200424191410.27570-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200424191410.27570-1-chris@chris-wilson.co.uk> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Drop rq->ring->vma peeking from error capture X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > static void engine_record_execlists(struct intel_engine_coredump *ee) > @@ -1231,8 +1235,10 @@ static void engine_record_execlists(struct intel_engine_coredump *ee) > struct i915_request * const *port = el->active; > unsigned int n = 0; > > - while (*port) > - record_request(*port++, &ee->execlist[n++]); > + while (*port) { > + if (record_request(*port++, &ee->execlist[n])) > + n++; > + } grrrr.... is this necessary? Besides, in a one line while loop we aren't supposed to use braces. Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx