From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guru Das Srinagesh Subject: Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro Date: Fri, 24 Apr 2020 15:17:56 -0700 Message-ID: <20200424221756.GB31118@codeaurora.org> References: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> <87ftctbe5l.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:34019 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgDXWSH (ORCPT ); Fri, 24 Apr 2020 18:18:07 -0400 Content-Disposition: inline In-Reply-To: <87ftctbe5l.fsf@intel.com> Sender: linux-pwm-owner@vger.kernel.org List-Id: linux-pwm@vger.kernel.org To: Jani Nikula Cc: linux-pwm@vger.kernel.org, David Collins , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Subbaraman Narayanamurthy On Fri, Apr 24, 2020 at 09:17:58AM +0300, Jani Nikula wrote: > On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: > > Since the PWM framework is switching struct pwm_state.duty_cycle's > > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL > > to handle a 64-bit dividend. > > > > To: Jani Nikula > > Cc: Joonas Lahtinen > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Chris Wilson > > Cc: "Ville Syrjälä" > > Cc: intel-gfx@lists.freedesktop.org > > Cc: dri-devel@lists.freedesktop.org > > > > Superfluous blank line. Will remove. > > Anyway, please preserve the existing acks and reviews [1] so people > don't have to do it again. > > BR, > Jani. > > [1] http://lore.kernel.org/r/87h7yleb0i.fsf@intel.com I dropped your Acked-by as the patch had to changed to resolve a merge conflict when I rebased to tip. Could you please re-review this patch? Thank you. Guru Das. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93EDDC55185 for ; Sat, 25 Apr 2020 08:42:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75B0B2071E for ; Sat, 25 Apr 2020 08:42:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75B0B2071E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DACBF6E1B7; Sat, 25 Apr 2020 08:42:47 +0000 (UTC) Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6577E6E0DA; Fri, 24 Apr 2020 22:17:57 +0000 (UTC) Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 24 Apr 2020 15:17:56 -0700 Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg01-sd.qualcomm.com with ESMTP; 24 Apr 2020 15:17:56 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id D1A8C4C90; Fri, 24 Apr 2020 15:17:56 -0700 (PDT) Date: Fri, 24 Apr 2020 15:17:56 -0700 From: Guru Das Srinagesh To: Jani Nikula Subject: Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro Message-ID: <20200424221756.GB31118@codeaurora.org> References: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> <87ftctbe5l.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87ftctbe5l.fsf@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Mailman-Approved-At: Sat, 25 Apr 2020 08:42:24 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, David Collins , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Thierry Reding , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Subbaraman Narayanamurthy Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBBcHIgMjQsIDIwMjAgYXQgMDk6MTc6NThBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAyMSBBcHIgMjAyMCwgR3VydSBEYXMgU3JpbmFnZXNoIDxndXJ1c0Bjb2Rl YXVyb3JhLm9yZz4gd3JvdGU6Cj4gPiBTaW5jZSB0aGUgUFdNIGZyYW1ld29yayBpcyBzd2l0Y2hp bmcgc3RydWN0IHB3bV9zdGF0ZS5kdXR5X2N5Y2xlJ3MKPiA+IGRhdGF0eXBlIHRvIHU2NCwgcHJl cGFyZSBmb3IgdGhpcyB0cmFuc2l0aW9uIGJ5IHVzaW5nIERJVl9ST1VORF9VUF9VTEwKPiA+IHRv IGhhbmRsZSBhIDY0LWJpdCBkaXZpZGVuZC4KPiA+Cj4gPiBUbzogSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5s YWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxp bnV4LmllPgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiA+IENjOiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+IENjOiAiVmlsbGUgU3ly asOkbMOkIiA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzogaW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiA+Cj4gCj4gU3VwZXJmbHVvdXMgYmxhbmsgbGluZS4KCldpbGwgcmVtb3ZlLgoKPiAK PiBBbnl3YXksIHBsZWFzZSBwcmVzZXJ2ZSB0aGUgZXhpc3RpbmcgYWNrcyBhbmQgcmV2aWV3cyBb MV0gc28gcGVvcGxlCj4gZG9uJ3QgaGF2ZSB0byBkbyBpdCBhZ2Fpbi4KPiAKPiBCUiwKPiBKYW5p Lgo+IAo+IFsxXSBodHRwOi8vbG9yZS5rZXJuZWwub3JnL3IvODdoN3lsZWIwaS5mc2ZAaW50ZWwu Y29tCgpJIGRyb3BwZWQgeW91ciBBY2tlZC1ieSBhcyB0aGUgcGF0Y2ggaGFkIHRvIGNoYW5nZWQg dG8gcmVzb2x2ZSBhIG1lcmdlCmNvbmZsaWN0IHdoZW4gSSByZWJhc2VkIHRvIHRpcC4gQ291bGQg eW91IHBsZWFzZSByZS1yZXZpZXcgdGhpcyBwYXRjaD8KClRoYW5rIHlvdS4KCkd1cnUgRGFzLgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06FC4C54FCB for ; Fri, 24 Apr 2020 22:25:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC3FC20736 for ; Fri, 24 Apr 2020 22:25:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC3FC20736 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 670906E0DA; Fri, 24 Apr 2020 22:25:52 +0000 (UTC) Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6577E6E0DA; Fri, 24 Apr 2020 22:17:57 +0000 (UTC) Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 24 Apr 2020 15:17:56 -0700 Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg01-sd.qualcomm.com with ESMTP; 24 Apr 2020 15:17:56 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id D1A8C4C90; Fri, 24 Apr 2020 15:17:56 -0700 (PDT) Date: Fri, 24 Apr 2020 15:17:56 -0700 From: Guru Das Srinagesh To: Jani Nikula Message-ID: <20200424221756.GB31118@codeaurora.org> References: <4a3acf8673c08308848fb7ae73d992b6feb758d3.1587523702.git.gurus@codeaurora.org> <87ftctbe5l.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87ftctbe5l.fsf@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Mailman-Approved-At: Fri, 24 Apr 2020 22:25:51 +0000 Subject: Re: [Intel-gfx] [PATCH v13 01/11] drm/i915: Use 64-bit division macro X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, David Collins , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Subbaraman Narayanamurthy Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gRnJpLCBBcHIgMjQsIDIwMjAgYXQgMDk6MTc6NThBTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVHVlLCAyMSBBcHIgMjAyMCwgR3VydSBEYXMgU3JpbmFnZXNoIDxndXJ1c0Bjb2Rl YXVyb3JhLm9yZz4gd3JvdGU6Cj4gPiBTaW5jZSB0aGUgUFdNIGZyYW1ld29yayBpcyBzd2l0Y2hp bmcgc3RydWN0IHB3bV9zdGF0ZS5kdXR5X2N5Y2xlJ3MKPiA+IGRhdGF0eXBlIHRvIHU2NCwgcHJl cGFyZSBmb3IgdGhpcyB0cmFuc2l0aW9uIGJ5IHVzaW5nIERJVl9ST1VORF9VUF9VTEwKPiA+IHRv IGhhbmRsZSBhIDY0LWJpdCBkaXZpZGVuZC4KPiA+Cj4gPiBUbzogSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5s YWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxp bnV4LmllPgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiA+IENjOiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+IENjOiAiVmlsbGUgU3ly asOkbMOkIiA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzogaW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiA+Cj4gCj4gU3VwZXJmbHVvdXMgYmxhbmsgbGluZS4KCldpbGwgcmVtb3ZlLgoKPiAK PiBBbnl3YXksIHBsZWFzZSBwcmVzZXJ2ZSB0aGUgZXhpc3RpbmcgYWNrcyBhbmQgcmV2aWV3cyBb MV0gc28gcGVvcGxlCj4gZG9uJ3QgaGF2ZSB0byBkbyBpdCBhZ2Fpbi4KPiAKPiBCUiwKPiBKYW5p Lgo+IAo+IFsxXSBodHRwOi8vbG9yZS5rZXJuZWwub3JnL3IvODdoN3lsZWIwaS5mc2ZAaW50ZWwu Y29tCgpJIGRyb3BwZWQgeW91ciBBY2tlZC1ieSBhcyB0aGUgcGF0Y2ggaGFkIHRvIGNoYW5nZWQg dG8gcmVzb2x2ZSBhIG1lcmdlCmNvbmZsaWN0IHdoZW4gSSByZWJhc2VkIHRvIHRpcC4gQ291bGQg eW91IHBsZWFzZSByZS1yZXZpZXcgdGhpcyBwYXRjaD8KClRoYW5rIHlvdS4KCkd1cnUgRGFzLgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK