From: Sam Ravnborg <sam@ravnborg.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, bpf@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>,
Christian Brauner <christian@brauner.io>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Jonathan Corbet <corbet@lwn.net>, KP Singh <kpsingh@chromium.org>,
Martin KaFai Lau <kafai@fb.com>,
Michal Marek <michal.lkml@markovi.net>,
Song Liu <songliubraving@fb.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Yonghong Song <yhs@fb.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 00/16] kbuild: support 'userprogs' syntax
Date: Sat, 25 Apr 2020 13:53:03 +0200 [thread overview]
Message-ID: <20200425115303.GA10048@ravnborg.org> (raw)
In-Reply-To: <20200423073929.127521-1-masahiroy@kernel.org>
Hi Masahiro
On Thu, Apr 23, 2020 at 04:39:13PM +0900, Masahiro Yamada wrote:
>
> Several Makefiles use 'hostprogs' for building the code for
> the host architecture is not appropriate.
>
> This is just because Kbuild does not provide the syntax to do it.
>
> This series introduce 'userprogs' syntax and use it from
> sample and bpf Makefiles.
>
> Sam worked on this in 2014.
> https://lkml.org/lkml/2014/7/13/154
I wonder how you managed to dig that up, but thanks for the reference.
Back then we would fail buiulding without any libc - you have solved
this nicely in this patch-set.
>
> He used 'uapiprogs-y' but I just thought the meaning of
> "UAPI programs" is unclear.
>
> Naming is one the most difficult parts of this.
>
> I chose 'userprogs'.
> Anothor choice I had in my mind was 'targetprogs'.
>
> If you can test this series quickly by
> 'make allmodconfig samples/'
>
> When building objects for userspace, [U] is displayed.
>
> masahiro@oscar:~/workspace/linux$ make allmodconfig samples/
> [snip]
> AR samples/vfio-mdev/built-in.a
> CC [M] samples/vfio-mdev/mtty.o
...
>
>
> Masahiro Yamada (15):
> Documentation: kbuild: fix the section title format
> Revert "objtool: Skip samples subdirectory"
> kbuild: add infrastructure to build userspace programs
> net: bpfilter: use 'userprogs' syntax to build bpfilter_umh
> samples: seccomp: build sample programs for target architecture
> kbuild: doc: document the new syntax 'userprogs'
> samples: uhid: build sample program for target architecture
> samples: hidraw: build sample program for target architecture
> samples: connector: build sample program for target architecture
> samples: vfs: build sample programs for target architecture
> samples: pidfd: build sample program for target architecture
> samples: mei: build sample program for target architecture
> samples: auxdisplay: use 'userprogs' syntax
> samples: timers: use 'userprogs' syntax
> samples: watchdog: use 'userprogs' syntax
Nice work!
All patches are:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Sam Ravnborg (1):
> samples: uhid: fix warnings in uhid-example
>
> Documentation/kbuild/makefiles.rst | 185 +++++++++++++++++++++--------
> Makefile | 11 +-
> net/bpfilter/Makefile | 11 +-
> samples/Kconfig | 26 +++-
> samples/Makefile | 5 +-
> samples/auxdisplay/Makefile | 11 +-
> samples/connector/Makefile | 12 +-
> samples/hidraw/Makefile | 9 +-
> samples/mei/Makefile | 9 +-
> samples/pidfd/Makefile | 8 +-
> samples/seccomp/Makefile | 42 +------
> samples/timers/Makefile | 17 +--
> samples/uhid/.gitignore | 2 +
> samples/uhid/Makefile | 9 +-
> samples/uhid/uhid-example.c | 4 +-
> samples/vfs/Makefile | 11 +-
> samples/watchdog/Makefile | 10 +-
> scripts/Makefile.build | 5 +
> scripts/Makefile.clean | 2 +-
> scripts/Makefile.userprogs | 44 +++++++
> 20 files changed, 258 insertions(+), 175 deletions(-)
> create mode 100644 samples/uhid/.gitignore
> create mode 100644 scripts/Makefile.userprogs
>
> --
> 2.25.1
next prev parent reply other threads:[~2020-04-25 11:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 7:39 [PATCH 00/16] kbuild: support 'userprogs' syntax Masahiro Yamada
2020-04-23 7:39 ` [PATCH 01/16] Documentation: kbuild: fix the section title format Masahiro Yamada
2020-04-23 7:39 ` [PATCH 02/16] Revert "objtool: Skip samples subdirectory" Masahiro Yamada
2020-04-24 20:32 ` Josh Poimboeuf
2020-04-29 2:43 ` Masahiro Yamada
2020-04-23 7:39 ` [PATCH 03/16] kbuild: add infrastructure to build userspace programs Masahiro Yamada
2020-04-23 15:15 ` Masahiro Yamada
2020-04-23 7:39 ` [PATCH 04/16] net: bpfilter: use 'userprogs' syntax to build bpfilter_umh Masahiro Yamada
2020-04-28 1:46 ` kbuild test robot
2020-04-28 1:46 ` kbuild test robot
2020-04-28 1:46 ` kbuild test robot
2020-04-28 5:13 ` Masahiro Yamada
2020-04-28 5:13 ` Masahiro Yamada
2020-06-08 11:56 ` Michal Kubecek
2020-06-08 13:32 ` Masahiro Yamada
2020-06-30 6:30 ` Masahiro Yamada
2020-06-30 8:57 ` Michal Kubecek
2020-06-30 16:47 ` Alexei Starovoitov
2020-04-23 7:39 ` [PATCH 05/16] samples: seccomp: build sample programs for target architecture Masahiro Yamada
2020-04-23 7:39 ` [PATCH 06/16] kbuild: doc: document the new syntax 'userprogs' Masahiro Yamada
2020-04-23 7:39 ` [PATCH 07/16] samples: uhid: fix warnings in uhid-example Masahiro Yamada
2020-04-23 7:39 ` [PATCH 08/16] samples: uhid: build sample program for target architecture Masahiro Yamada
2020-04-23 7:39 ` [PATCH 09/16] samples: hidraw: " Masahiro Yamada
2020-04-23 7:39 ` [PATCH 10/16] samples: connector: " Masahiro Yamada
2020-04-23 7:39 ` [PATCH 11/16] samples: vfs: build sample programs " Masahiro Yamada
2020-04-23 7:39 ` [PATCH 12/16] samples: pidfd: build sample program " Masahiro Yamada
2020-04-23 7:39 ` [PATCH 13/16] samples: mei: " Masahiro Yamada
2020-04-23 7:39 ` [PATCH 14/16] samples: auxdisplay: use 'userprogs' syntax Masahiro Yamada
2020-04-23 11:50 ` Miguel Ojeda
2020-04-24 2:59 ` Masahiro Yamada
2020-04-23 7:39 ` [PATCH 15/16] samples: timers: " Masahiro Yamada
2020-04-23 7:39 ` [PATCH 16/16] samples: watchdog: " Masahiro Yamada
2020-04-25 11:53 ` Sam Ravnborg [this message]
2020-04-29 2:38 ` [PATCH 00/16] kbuild: support " Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425115303.GA10048@ravnborg.org \
--to=sam@ravnborg.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christian@brauner.io \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=tomas.winkler@intel.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.