All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Brian J. Tarricone" <brian@tarricone.org>
Cc: gregory.clement@bootlin.com, jason@lakedaemon.net,
	linux-arm-kernel@lists.infradead.org,
	sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH] arm/dts: Add DT block for Netgear ReadyNAS NV+ v2 LCD panel
Date: Sat, 25 Apr 2020 16:27:36 +0200	[thread overview]
Message-ID: <20200425142736.GC1095011@lunn.ch> (raw)
In-Reply-To: <20200425022409.2093354-1-brian@tarricone.org>

On Fri, Apr 24, 2020 at 07:24:09PM -0700, Brian J. Tarricone wrote:
> The NV+ v2 has a WH1602 LCD panel (which is just a rebranded HD44780),
> similar to the Netgear RN104, just with different GPIO assignments.
> 
> Signed-off-by: Brian J. Tarricone <brian@tarricone.org>

Hi Brian

The change itself looks O.K.

However, please could you change the subject to follow what other
kirkwood DT patches use:

arch/arm/boot/dts$ git log --oneline kirkwood-*
15382b7ea298 ARM: dts: kirkwood: synology: Fix rs5c372 RTC entry
644763224169 ARM: dts: kirkwood: ts219: disable the SoC's RTC
6a3b25173cd4 arch: arm: dts: kirkwood-rd88f6281: Remove disabled marvell,dsa reference
cb92e40411ef arch: arm: dts: Remove disabled marvell,dsa properties
b5f034845e70 ARM: dts: kirkwood: Fix polarity of GPIO fan lines
eb59e0920331 arm: dts: kirkwood*.dts: use SPDX-License-Identifier for board using GPL-2.0+
b3820aa10c1b arm: dts: kirkwood*.dts: use SPDX-License-Identifier for boards using GPL-2.0+/MIT
e7822263a7a5 arm: dts: kirkwood*.dts: use SPDX-License-Identifier for boards using GPL-2.0
5beaf4d7ce9e ARM: dts: kirkwood: Fix "debounce-interval" property misspelling

Yes, there is a bit of variance, but something like

ARM: dts: kirkwood: Readynas nv2: Add LCD panel

Thanks
	Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-04-25 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25  2:24 [PATCH] arm/dts: Add DT block for Netgear ReadyNAS NV+ v2 LCD panel Brian J. Tarricone
2020-04-25 14:27 ` Andrew Lunn [this message]
2020-04-25 19:28   ` [PATCH] ARM: dts: kirkwood: ReadyNAS NV+v2: Add " Brian J. Tarricone
2020-04-25 20:14     ` Andrew Lunn
2020-05-17 16:52     ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200425142736.GC1095011@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=brian@tarricone.org \
    --cc=gregory.clement@bootlin.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.