From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, Denis Ciocca <denis.ciocca@st.com>
Subject: Re: [PATCH v1 16/16] iio: st_sensors: Use get_unaligned_be24() and sign_extend32()
Date: Sat, 25 Apr 2020 17:53:45 +0100 [thread overview]
Message-ID: <20200425175345.693b2f36@archlinux> (raw)
In-Reply-To: <20200421003135.23060-16-andriy.shevchenko@linux.intel.com>
On Tue, 21 Apr 2020 03:31:35 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Use these functions instead of open-coding them.
>
> Cc: Denis Ciocca <denis.ciocca@st.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This one already has the header, so applied to the togreg branch of iio.git
and pushed out as testing with no changes :)
Jonathan
> ---
> drivers/iio/common/st_sensors/st_sensors_core.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/iio/common/st_sensors/st_sensors_core.c b/drivers/iio/common/st_sensors/st_sensors_core.c
> index 0e35ff06f9af..bfc39ef64718 100644
> --- a/drivers/iio/common/st_sensors/st_sensors_core.c
> +++ b/drivers/iio/common/st_sensors/st_sensors_core.c
> @@ -20,11 +20,6 @@
>
> #include "st_sensors_core.h"
>
> -static inline u32 st_sensors_get_unaligned_le24(const u8 *p)
> -{
> - return (s32)((p[0] | p[1] << 8 | p[2] << 16) << 8) >> 8;
> -}
> -
> int st_sensors_write_data_with_mask(struct iio_dev *indio_dev,
> u8 reg_addr, u8 mask, u8 data)
> {
> @@ -545,7 +540,7 @@ static int st_sensors_read_axis_data(struct iio_dev *indio_dev,
> else if (byte_for_channel == 2)
> *data = (s16)get_unaligned_le16(outdata);
> else if (byte_for_channel == 3)
> - *data = (s32)st_sensors_get_unaligned_le24(outdata);
> + *data = (s32)sign_extend32(get_unaligned_le24(outdata), 23);
>
> st_sensors_free_memory:
> kfree(outdata);
next prev parent reply other threads:[~2020-04-25 16:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 0:31 [PATCH v1 01/16] iio: adc: ad_sigma_delta: Use {get,put}_unaligned_be24() Andy Shevchenko
2020-04-21 0:31 ` [PATCH v1 02/16] iio: adc: mpc3422: Use get_unaligned_beXX() Andy Shevchenko
2020-04-25 16:14 ` Jonathan Cameron
2020-04-25 16:23 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 03/16] iio: adc: ti-ads124s08: Use get_unaligned_be24() Andy Shevchenko
2020-04-25 16:24 ` Jonathan Cameron
2020-04-25 17:01 ` Andy Shevchenko
2020-04-21 0:31 ` [PATCH v1 04/16] iio: dac: ltc2632: Use put_unaligned_be24() Andy Shevchenko
2020-04-25 16:26 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 05/16] iio: dac: ad5624r_spi: " Andy Shevchenko
2020-04-21 6:43 ` Sa, Nuno
2020-04-25 16:29 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 06/16] iio: dac: ad5446: " Andy Shevchenko
2020-04-25 16:31 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 07/16] iio: gyro: adis16130: Use get_unaligned_be24() Andy Shevchenko
2020-04-21 6:39 ` Sa, Nuno
2020-04-25 16:34 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 08/16] iio: health: afe4403: " Andy Shevchenko
2020-04-25 16:41 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 09/16] iio: light: si1133: " Andy Shevchenko
2020-04-25 16:41 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 10/16] iio: light: zopt2201: Use get_unaligned_le24() Andy Shevchenko
2020-04-25 16:42 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 11/16] iio: magnetometer: rm3100: Use get_unaligned_be24() Andy Shevchenko
2020-04-25 16:44 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 12/16] iio: pressure: hp206c: " Andy Shevchenko
2020-04-25 16:45 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 13/16] iio: pressure: ms5611: " Andy Shevchenko
2020-04-21 8:36 ` Tomasz Duszynski
2020-04-25 16:48 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 14/16] iio: pressure: zpa2326: Use get_unaligned_le24() Andy Shevchenko
2020-04-25 16:50 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 15/16] iio: temperature: max31856: Use get_unaligned_beXX() Andy Shevchenko
2020-04-25 16:51 ` Jonathan Cameron
2020-04-21 0:31 ` [PATCH v1 16/16] iio: st_sensors: Use get_unaligned_be24() and sign_extend32() Andy Shevchenko
2020-04-25 16:53 ` Jonathan Cameron [this message]
2020-04-25 17:04 ` Andy Shevchenko
2020-04-21 6:41 ` [PATCH v1 01/16] iio: adc: ad_sigma_delta: Use {get,put}_unaligned_be24() Sa, Nuno
2020-04-25 16:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200425175345.693b2f36@archlinux \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=denis.ciocca@st.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.