All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Biwen Li <biwen.li@oss.nxp.com>
Cc: ran.wang_1@nxp.com, robh+dt@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	jiafei.pan@nxp.com, Biwen Li <biwen.li@nxp.com>
Subject: Re: [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node
Date: Sun, 26 Apr 2020 21:17:52 +0800	[thread overview]
Message-ID: <20200426131751.GC30501@dragon> (raw)
In-Reply-To: <20200407064251.39244-1-biwen.li@oss.nxp.com>

On Tue, Apr 07, 2020 at 02:42:48PM +0800, Biwen Li wrote:
> From: Biwen Li <biwen.li@nxp.com>
> 
> The patch adds ftm_alarm0 DT node for Soc LX2160A
> FlexTimer1 module is used to wakeup the system in deep sleep
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index e5ee5591e52b..e0d8d68ce070 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -16,6 +16,10 @@
>  	#address-cells = <2>;
>  	#size-cells = <2>;
>  
> +	aliases {
> +		rtc1 = &ftm_alarm0;
> +	};
> +
>  	cpus {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> @@ -768,6 +772,20 @@
>  			timeout-sec = <30>;
>  		};
>  
> +		rcpm: rcpm@1e34040 {

Keep the node sort in unit-address.  Also, try to use a generic node
name.

Shawn

> +			compatible = "fsl,lx2160a-rcpm", "fsl,qoriq-rcpm-2.1+";
> +			reg = <0x0 0x1e34040 0x0 0x1c>;
> +			#fsl,rcpm-wakeup-cells = <7>;
> +			little-endian;
> +		};
> +
> +		ftm_alarm0: timer@2800000 {
> +			compatible = "fsl,lx2160a-ftm-alarm";
> +			reg = <0x0 0x2800000 0x0 0x10000>;
> +			fsl,rcpm-wakeup = <&rcpm 0x0 0x0 0x0 0x0 0x4000 0x0 0x0>;
> +			interrupts = <0 44 4>;

IRQ_TYPE_LEVEL_HIGH

Shawn

> +		};
> +
>  		usb0: usb@3100000 {
>  			compatible = "snps,dwc3";
>  			reg = <0x0 0x3100000 0x0 0x10000>;
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2020-04-26 13:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07  6:42 [RESEND 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node Biwen Li
2020-04-07  6:42 ` [RESEND 2/4] arm64: dts: ls1028a: Add " Biwen Li
2020-04-07  6:42 ` [RESEND 3/4] arm64: dts: ls1012a/ls1043a/ls1046a/ls1088a/ls208xa: add ftm_alarm0 node Biwen Li
2020-04-07  6:42 ` [RESEND 4/4] arm: dts: ls1021a: add ftm_alarm0 DT node Biwen Li
2020-04-26 13:17 ` Shawn Guo [this message]
2020-05-08  9:35   ` [RESEND 1/4] arm64: dts: lx2160a: " Biwen Li (OSS)
2020-05-11 14:16     ` Shawn Guo
2020-05-20  8:27       ` Biwen Li (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200426131751.GC30501@dragon \
    --to=shawnguo@kernel.org \
    --cc=biwen.li@nxp.com \
    --cc=biwen.li@oss.nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jiafei.pan@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ran.wang_1@nxp.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.