From: Shawn Guo <shawnguo@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
Anson Huang <Anson.Huang@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, soc@kernel.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: imx: fix compile-testing
Date: Sun, 26 Apr 2020 21:28:14 +0800 [thread overview]
Message-ID: <20200426132812.GD30501@dragon> (raw)
In-Reply-To: <20200408190314.695067-1-arnd@arndb.de>
On Wed, Apr 08, 2020 at 09:02:57PM +0200, Arnd Bergmann wrote:
> It is nice to allow compile-testing the firmware drivers, but this
> fails when the dependency is a loadable module:
>
> aarch64-linux-ld: drivers/firmware/imx/scu-pd.o: in function `imx_sc_pd_power':
> scu-pd.c:(.text+0xd8): undefined reference to `imx_scu_call_rpc'
> aarch64-linux-ld: scu-pd.c:(.text+0x108): undefined reference to `imx_scu_call_rpc'
> aarch64-linux-ld: drivers/firmware/imx/scu-pd.o: in function `imx_sc_pd_probe':
>
> Change the dependencies to ensure that any driver we depend on is
> either reachable or we are compile-testing and it is disabled,
> effectively reverting most of the previous changes that turned
> out to be incorrect.
>
> Fixes: a9f85f93ed73 ("firmware: imx: add COMPILE_TEST support")
> Fixes: 5b00b8375416 ("firmware: imx: add COMPILE_TEST for IMX_SCU driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Shawn Guo <shawnguo@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-04-26 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 19:02 [PATCH] firmware: imx: fix compile-testing Arnd Bergmann
2020-04-08 19:02 ` Arnd Bergmann
2020-04-26 13:28 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200426132812.GD30501@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=arnd@arndb.de \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.