From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: enable rx duration report default for wmi tlv
Date: Mon, 27 Apr 2020 05:01:45 +0000 (UTC) [thread overview]
Message-ID: <20200427050145.6B036C433F2@smtp.codeaurora.org> (raw)
In-Reply-To: <20200423022758.5365-1-wgong@codeaurora.org>
Wen Gong <wgong@codeaurora.org> wrote:
> When run command "iw dev wlan0 station dump", the rx duration is 0.
> When firmware indicate WMI_UPDATE_STATS_EVENTID, extended flag of
> statsis not set by default, so firmware do not report rx duration.
>
> one sample:
> localhost # iw wlan0 station dump
> Station c4:04:15:5d:97:22 (on wlan0)
> inactive time: 48 ms
> rx bytes: 21670
> rx packets: 147
> tx bytes: 11529
> tx packets: 100
> tx retries: 88
> tx failed: 36
> beacon loss: 1
> beacon rx: 31
> rx drop misc: 47
> signal: -72 [-74, -75] dBm
> signal avg: -71 [-74, -75] dBm
> beacon signal avg: -71 dBm
> tx bitrate: 54.0 MBit/s MCS 3 40MHz
> rx bitrate: 1.0 MBit/s
> rx duration: 0 us
>
> This patch enable firmware's extened flag of stats by setting flag
> WMI_TLV_STAT_PEER_EXTD of ar->fw_stats_req_mask which is set in
> ath10k_core_init_firmware_features via WMI_REQUEST_STATS_CMDID.
>
> After apply this patch, rx duration show value with the command:
> Station c4:04:15:5d:97:22 (on wlan0)
> inactive time: 883 ms
> rx bytes: 44289
> rx packets: 265
> tx bytes: 10838
> tx packets: 93
> tx retries: 899
> tx failed: 103
> beacon loss: 0
> beacon rx: 78
> rx drop misc: 46
> signal: -71 [-74, -76] dBm
> signal avg: -70 [-74, -76] dBm
> beacon signal avg: -70 dBm
> tx bitrate: 54.0 MBit/s MCS 3 40MHz
> rx bitrate: 1.0 MBit/s
> rx duration: 358004 us
>
> This patch do not have side effect for all chips, because function
> ath10k_debug_fw_stats_request is already exported to debugfs
> "fw_stats" and WMI_REQUEST_STATS_CMDID is safely sent after condition
> checked by ath10k_peer_stats_enabled in ath10k_sta_statistics.
>
> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
4913e675630e ath10k: enable rx duration report default for wmi tlv
--
https://patchwork.kernel.org/patch/11504895/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2020-04-27 5:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 2:27 [PATCH] ath10k: enable rx duration report default for wmi tlv Wen Gong
2020-04-23 2:27 ` Wen Gong
2020-04-27 5:01 ` Kalle Valo
2020-04-27 5:01 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427050145.6B036C433F2@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.