From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: add statistics of tx retries and tx failed when tx complete disable
Date: Mon, 27 Apr 2020 05:02:23 +0000 (UTC) [thread overview]
Message-ID: <20200427050223.078CBC433F2@smtp.codeaurora.org> (raw)
In-Reply-To: <20200423024134.10601-1-wgong@codeaurora.org>
Wen Gong <wgong@codeaurora.org> wrote:
> When tx complete is disabled, all tx status will be set with status
> HTT_TX_COMPL_STATE_ACK and indicate to mac80211 by ieee80211_tx_status,
> then it does not have the statistics for retries and failed packets.
> count of tx retries and tx failed of command "iw wlan0 station dump"
> are both 0. If tx complete is not disabled, then firmware report the
> tx status and ath10k indicate the status to mac80211, then mac80211
> save the statistics and command "iw wlan0 station dump" show them.
>
> for example:
> localhost ~ # iw dev wlan0 station dump
> Station 3c:28:6d:96:fd:69 (on wlan0)
> inactive time: 5 ms
> rx bytes: 1325012
> rx packets: 6477
> tx bytes: 85264
> tx packets: 518
> tx retries: 0
> tx failed: 0
>
> This patch only effect chips with tx complete disabled, e.g. SDIO.
>
> with this patch, output of command "iw dev wlan0 station dump":
> Station c4:04:15:5d:97:22 (on wlan0)
> inactive time: 608 ms
> rx bytes: 180366
> rx packets: 991
> tx bytes: 98765577
> tx packets: 64624
> tx retries: 14682
> tx failed: 47086
>
> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
59a022cc14cf ath10k: add statistics of tx retries and tx failed when tx complete disable
--
https://patchwork.kernel.org/patch/11504903/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-04-27 5:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 2:41 [PATCH] ath10k: add statistics of tx retries and tx failed when tx complete disable Wen Gong
2020-04-23 2:41 ` Wen Gong
2020-04-27 5:02 ` Kalle Valo [this message]
2020-04-27 5:02 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427050223.078CBC433F2@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=wgong@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.